You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Copilot (via GitHub)" <gi...@apache.org> on 2025/08/05 18:30:53 UTC

Re: [PR] chore(npm): bump node engine, build fresh package-lock.json [superset]

Copilot commented on code in PR #34306:
URL: https://github.com/apache/superset/pull/34306#discussion_r2255047660


##########
superset-frontend/package.json:
##########
@@ -121,7 +121,7 @@
     "@visx/scale": "^3.5.0",
     "@visx/tooltip": "^3.0.0",
     "@visx/xychart": "^3.5.1",
-    "ag-grid-community": "^34.0.2",
+    "ag-grid-community": "34.0.2",

Review Comment:
   The version format changed from "^34.0.2" to "34.0.2", removing the caret prefix. This pins the dependency to an exact version, which may prevent automatic minor and patch updates. Consider if this strict pinning is intentional.
   ```suggestion
       "ag-grid-community": "^34.0.2",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org