You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/06/25 10:57:58 UTC
Review Request 35864: Cannot stop Storm components (systemwide umask
027 + non-root)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35864/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-12140
https://issues.apache.org/jira/browse/AMBARI-12140
Repository: ambari
Description
-------
Running as non-root, umask 027 and custom service account.
Stop does not stop storm components, just deletes the .pid file and leaves
processes running.
[root@c6401 storm]# ls -l
total 4
-rw-r----- 1 jstorm jhadoop 6 Jun 24 14:14 drpc.pid
Shouldn't the check for the pid be run as the custom service account?
Otherwise, it can't read the pid and deletes it. Need to fix this for all
components of Storm.
2015-06-24 14:15:57,863 - Execute['ambari-sudo.sh kill `cat /var/run/storm/drpc.pid`'] {'not_if': '! (ls /var/run/storm/drpc.pid >/dev/null 2>&1 && ps -p `cat /var/run/storm/drpc.pid` >/dev/null 2>&1)'}
2015-06-24 14:15:57,869 - Skipping Execute['ambari-sudo.sh kill `cat /var/run/storm/drpc.pid`'] due to not_if
2015-06-24 14:15:57,870 - Execute['ambari-sudo.sh kill -9 `cat /var/run/storm/drpc.pid`'] {'not_if': 'sleep 2; ! (ls /var/run/storm/drpc.pid >/dev/null 2>&1 && ps -p `cat /var/run/storm/drpc.pid` >/dev/null 2>&1) || sleep 20; ! (ls /var/run/storm/drpc.pid >/dev/null 2>&1 && ps -p `cat /var/run/storm/drpc.pid` >/dev/null 2>&1)', 'ignore_failures': True}
2015-06-24 14:15:59,881 - Skipping Execute['ambari-sudo.sh kill -9 `cat /var/run/storm/drpc.pid`'] due to not_if
2015-06-24 14:15:59,881 - File['/var/run/storm/drpc.pid'] {'action': ['delete']}
2015-06-24 14:15:59,905 - Deleting File['/var/run/storm/drpc.pid']
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 43378a9
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 01d0a9f
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py 0080beb
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 2d049a9
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py fc97130
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py c377715
ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 5b924ae
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py 44b48de
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 4548b8d
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 761bb64
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py c4a261e
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py 926e57e
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 0a46155
Diff: https://reviews.apache.org/r/35864/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 35864: Cannot stop Storm components (systemwide
umask 027 + non-root)
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35864/#review89333
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Червень 25, 2015, 8:57 до полудня, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35864/
> -----------------------------------------------------------
>
> (Updated Червень 25, 2015, 8:57 до полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-12140
> https://issues.apache.org/jira/browse/AMBARI-12140
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Running as non-root, umask 027 and custom service account.
>
> Stop does not stop storm components, just deletes the .pid file and leaves
> processes running.
>
>
>
>
> [root@c6401 storm]# ls -l
> total 4
> -rw-r----- 1 jstorm jhadoop 6 Jun 24 14:14 drpc.pid
>
>
> Shouldn't the check for the pid be run as the custom service account?
> Otherwise, it can't read the pid and deletes it. Need to fix this for all
> components of Storm.
>
>
>
>
> 2015-06-24 14:15:57,863 - Execute['ambari-sudo.sh kill `cat /var/run/storm/drpc.pid`'] {'not_if': '! (ls /var/run/storm/drpc.pid >/dev/null 2>&1 && ps -p `cat /var/run/storm/drpc.pid` >/dev/null 2>&1)'}
> 2015-06-24 14:15:57,869 - Skipping Execute['ambari-sudo.sh kill `cat /var/run/storm/drpc.pid`'] due to not_if
> 2015-06-24 14:15:57,870 - Execute['ambari-sudo.sh kill -9 `cat /var/run/storm/drpc.pid`'] {'not_if': 'sleep 2; ! (ls /var/run/storm/drpc.pid >/dev/null 2>&1 && ps -p `cat /var/run/storm/drpc.pid` >/dev/null 2>&1) || sleep 20; ! (ls /var/run/storm/drpc.pid >/dev/null 2>&1 && ps -p `cat /var/run/storm/drpc.pid` >/dev/null 2>&1)', 'ignore_failures': True}
> 2015-06-24 14:15:59,881 - Skipping Execute['ambari-sudo.sh kill -9 `cat /var/run/storm/drpc.pid`'] due to not_if
> 2015-06-24 14:15:59,881 - File['/var/run/storm/drpc.pid'] {'action': ['delete']}
> 2015-06-24 14:15:59,905 - Deleting File['/var/run/storm/drpc.pid']
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 43378a9
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 01d0a9f
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py 0080beb
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 2d049a9
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py fc97130
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py c377715
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 5b924ae
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py 44b48de
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 4548b8d
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py 761bb64
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py c4a261e
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py 926e57e
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 0a46155
>
> Diff: https://reviews.apache.org/r/35864/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>