[jira] [Commented] (PHOENIX-6749) Replace deprecated HBase 1.x API calls

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603690#comment-17603690 ] 

ASF GitHub Bot commented on PHOENIX-6749:
-----------------------------------------

gjacoby126 commented on code in PR #1497:
URL: https://github.com/apache/phoenix/pull/1497#discussion_r969913820


##########
phoenix-core/src/it/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilterIT.java:
##########
@@ -120,7 +122,12 @@ public void testOtherTablesAutoPass() throws Exception {
     //Cell is nonsense but we should auto pass because the table name's not System.Catalog
     WAL.Entry entry = new WAL.Entry(new WALKeyImpl(REGION,
         TableName.valueOf(TestUtil.ENTITY_HISTORY_TABLE_NAME), System.currentTimeMillis()), new WALEdit());
-    entry.getEdit().add(CellUtil.createCell(Bytes.toBytes("foo")));
+    entry.getEdit().add(
+            ExtendedCellBuilderFactory.create(

Review Comment:
   @Aarchy - looks like this change is still remaining to be done.



##########
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/MultiHfileOutputFormat.java:
##########
@@ -195,7 +196,7 @@ public void write(TableRowkeyPair row, V cell)
 
                 // we now have the proper WAL writer. full steam ahead
                 if (cell.getTimestamp() == HConstants.LATEST_TIMESTAMP) {
-                    CellUtil.setTimestamp(cell, this.now);
+                    PrivateCellUtil.setTimestamp(cell, this.now);

Review Comment:
   Looks like this still needs to be done. 





> Replace deprecated HBase 1.x API calls
> --------------------------------------
>
>                 Key: PHOENIX-6749
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6749
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: connectors, core, queryserver
>            Reporter: Istvan Toth
>            Assignee: Aron Attila Meszaros
>            Priority: Major
>
> Now that we no longer care about Hbase 1.x compatibility, we should replace the deprecated Hbase 1.x API calls with HBase 2 API calls.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)