You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Matt Burgess <ma...@gmail.com> on 2015/06/09 21:41:10 UTC
Review Request 35263: DRILL-3199: GenericAccessor doesn't support
isNull
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35263/
-----------------------------------------------------------
Review request for drill.
Repository: drill-git
Description
-------
When calling isNull() from a result set, if the method gets delegated/propagated to a GenericAccessor, it throws an UnsupportedOperationException. Since GenericAccessor uses its underlying ValueVector for most other methods, I think it should also delegate the isNull() method and return whatever comes back from the ValueVector.isNull() call.
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java 347cf26
exec/java-exec/src/test/java/org/apache/drill/exec/vector/accessor/GenericAccessorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35263/diff/
Testing
-------
Thanks,
Matt Burgess
Re: Review Request 35263: DRILL-3199: GenericAccessor doesn't support
isNull
Posted by Matt Burgess <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35263/
-----------------------------------------------------------
(Updated June 29, 2015, 1:22 a.m.)
Review request for drill.
Changes
-------
Fixed unit tests to expect the correct exception
Repository: drill-git
Description
-------
When calling isNull() from a result set, if the method gets delegated/propagated to a GenericAccessor, it throws an UnsupportedOperationException. Since GenericAccessor uses its underlying ValueVector for most other methods, I think it should also delegate the isNull() method and return whatever comes back from the ValueVector.isNull() call.
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/vector/accessor/GenericAccessor.java 347cf26
exec/java-exec/src/test/java/org/apache/drill/exec/vector/accessor/GenericAccessorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35263/diff/
Testing
-------
Thanks,
Matt Burgess