You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/10/20 16:52:58 UTC
[GitHub] [incubator-mxnet] barry-jin opened a new pull request #20685: [WIP][2.0] Bump NumPy to >= 1.20.0
barry-jin opened a new pull request #20685:
URL: https://github.com/apache/incubator-mxnet/pull/20685
## Description ##
(Brief description on what this PR is about)
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20685: [WIP][2.0] Bump NumPy to >= 1.20.0
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20685:
URL: https://github.com/apache/incubator-mxnet/pull/20685#issuecomment-965636566
@mxnet-bot run ci [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20685: [WIP][2.0] Bump NumPy to >= 1.20.0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20685:
URL: https://github.com/apache/incubator-mxnet/pull/20685#issuecomment-947851964
Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, edge, sanity, windows-cpu, website, unix-cpu, windows-gpu, clang, unix-gpu, miscellaneous, centos-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20685: [2.0] Bump NumPy to >= 1.20.0
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20685:
URL: https://github.com/apache/incubator-mxnet/pull/20685#discussion_r748431462
##########
File path: ci/docker/Dockerfile.build.ubuntu
##########
@@ -132,9 +132,17 @@ RUN cd /usr/local/src && \
tar xf apache-rat-0.13-bin.tar.gz
# Python & cmake
+# We need to remove NumPy from requirements for ubuntu18.04
+# because ubuntu18.04 has only python3.6, which is not supported
+# for NumPy >= 1.20.0
Review comment:
Ubuntu 18.04 is only used by the tensorrt image and only because in December 2020 NVidia hadn't made tensorrt available for 20.04 yet. (https://github.com/apache/incubator-mxnet/commit/afc76b0f82839dfe00f7cab04be6de3df94564fe)
Instead of going throgh the python3.6 trouble, I think you can just update https://github.com/apache/incubator-mxnet/blob/16fed6ed46c84137853ac47a019c370d2605e832/ci/docker/docker-compose.yml#L101-L110 and https://github.com/apache/incubator-mxnet/blob/16fed6ed46c84137853ac47a019c370d2605e832/ci/docker/Dockerfile.build.ubuntu#L164-L170 to ubuntu 20.04
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20685: [WIP][2.0] Bump NumPy to >= 1.20.0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20685:
URL: https://github.com/apache/incubator-mxnet/pull/20685#issuecomment-965636620
Jenkins CI successfully triggered : [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on a change in pull request #20685: [2.0] Bump NumPy to >= 1.20.0
Posted by GitBox <gi...@apache.org>.
barry-jin commented on a change in pull request #20685:
URL: https://github.com/apache/incubator-mxnet/pull/20685#discussion_r748448086
##########
File path: .github/workflows/os_x_mklbuild.yml
##########
@@ -44,6 +44,7 @@ jobs:
- name: Test project
run: |
+ python -m pytest -n 4 --durations=50 --verbose tests/python/unittest/test_numpy_op.py -m 'not serial'
Review comment:
Yes, mkl build will hang on some tests, so I make it fail early on CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20685: [WIP][2.0] Bump NumPy to >= 1.20.0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20685:
URL: https://github.com/apache/incubator-mxnet/pull/20685#issuecomment-964858171
Jenkins CI successfully triggered : [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20685: [2.0] Bump NumPy to >= 1.20.0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20685:
URL: https://github.com/apache/incubator-mxnet/pull/20685#issuecomment-965944123
Jenkins CI successfully triggered : [centos-gpu, centos-cpu, website, miscellaneous, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20685: [WIP][2.0] Bump NumPy to >= 1.20.0
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20685:
URL: https://github.com/apache/incubator-mxnet/pull/20685#issuecomment-964858128
@mxnet-bot run ci [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20685: [2.0] Bump NumPy to >= 1.20.0
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20685:
URL: https://github.com/apache/incubator-mxnet/pull/20685#issuecomment-965944089
@mxnet-bot run ci [centos-cpu, centos-gpu, unix-gpu, miscellaneous, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20685: [2.0] Bump NumPy to >= 1.20.0
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20685:
URL: https://github.com/apache/incubator-mxnet/pull/20685#discussion_r748426653
##########
File path: .github/workflows/os_x_mklbuild.yml
##########
@@ -44,6 +44,7 @@ jobs:
- name: Test project
run: |
+ python -m pytest -n 4 --durations=50 --verbose tests/python/unittest/test_numpy_op.py -m 'not serial'
Review comment:
Isn't test_numpy_op.py already included by the next line? Or is it just a temporary change to fail early on CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org