[jira] [Commented] (PHOENIX-5783) Implement starttime in IndexTool for rebuild and verification

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119184#comment-17119184 ] 

Hadoop QA commented on PHOENIX-5783:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/13004293/PHOENIX-5783.4.x.001.patch
  against 4.x branch at commit 45929b5a74feddb647571c7d7c057142973b45b0.
  ATTACHMENT ID: 13004293

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +                    "CREATE INDEX "+indexTableName+" ON "+dataTableFullName+" (val3) INCLUDE(val5)"));
+            conn.createStatement().execute("UPSERT INTO "+dataTableFullName+"(key1, key2, val1, val2) VALUES (4,5,'abc',3)");
+            conn.createStatement().execute("UPSERT INTO "+dataTableFullName+"(key1, key2, val1, val2) VALUES (1,2,'abc',3)");
+            conn.createStatement().execute("UPSERT INTO "+dataTableFullName+"(key1, key2, val3, val4) VALUES (1,2,4,1.2)");
+            conn.createStatement().execute("UPSERT INTO "+dataTableFullName+"(key1, key2, val5, val6) VALUES (1,2,5,'def')");
+                it = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName,
+                        null, 0, IndexTool.IndexVerifyType.ONLY, "-st", String.valueOf(t0),"-et", String.valueOf(t2));
+                it = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName,
+                        null, 0, IndexTool.IndexVerifyType.ONLY, "-st", String.valueOf(t1),"-et", String.valueOf(t2));
+                it = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName,

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForNonTxGlobalIndexIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3901//testReport/
Code Coverage results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3901//artifact/phoenix-core/target/site/jacoco/index.html
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3901//console

This message is automatically generated.

> Implement starttime in IndexTool for rebuild and verification
> -------------------------------------------------------------
>
>                 Key: PHOENIX-5783
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5783
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Swaroopa Kadam
>            Assignee: Swaroopa Kadam
>            Priority: Major
>         Attachments: PHOENIX-5783.4.x.001.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> IndexTool's inline verification and rebuild should be able to perform the logic for a specified time range given by starttime parameters. 
>  
> This feature is only for indexes on non-transactional tables
> .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)