You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/05/21 13:15:25 UTC

[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1357: ZOOKEEPER-3835: Deprecate IOUtils copyBytes

ctubbsii commented on a change in pull request #1357:
URL: https://github.com/apache/zookeeper/pull/1357#discussion_r428643357



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/IOUtils.java
##########
@@ -68,6 +68,7 @@ public static void cleanup(Logger log, Closeable... closeables) {
 
     /**
      * Copies from one stream to another.
+     * Deprecated. No longer used in ZK.

Review comment:
       If it's deprecated, it should use the `@Deprecated` annotation, and have a useful `@deprecated` javadoc message for any current callers.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org