You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/03/13 09:43:15 UTC

Review Request: SQOOP-946 Sqoop2: Integration: Enhance the POC test case

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9896/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've changed a bit the temporary path generation logic by appending method name as another directory to the path. The reasoning is to support test cases with multiple tests (each test will have it's own sandbox). I've also extracted few easily reusable methods and added new test.


This addresses bug SQOOP-946.
    https://issues.apache.org/jira/browse/SQOOP-946


Diffs
-----

  test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java 5631144f8f0575d7507055f70b42e9edfc762904 
  test/src/test/java/org/apache/sqoop/integration/connector/ConnectorTestCase.java 14f7dc42f30d86a9e7c56fda9ea355c49fec07d5 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java 05a799ce09757ca8ed5338a465fae4477adec744 

Diff: https://reviews.apache.org/r/9896/diff/


Testing
-------

Integration tests seems to be passing.


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-946 Sqoop2: Integration: Enhance the POC test case

Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9896/#review18387
-----------------------------------------------------------

Ship it!


Thanks Jarcec.

- Kathleen Ting


On March 17, 2013, 8:07 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9896/
> -----------------------------------------------------------
> 
> (Updated March 17, 2013, 8:07 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've changed a bit the temporary path generation logic by appending method name as another directory to the path. The reasoning is to support test cases with multiple tests (each test will have it's own sandbox). I've also extracted few easily reusable methods and added new test.
> 
> 
> This addresses bug SQOOP-946.
>     https://issues.apache.org/jira/browse/SQOOP-946
> 
> 
> Diffs
> -----
> 
>   test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java 5631144f8f0575d7507055f70b42e9edfc762904 
>   test/src/test/java/org/apache/sqoop/integration/connector/ConnectorTestCase.java 14f7dc42f30d86a9e7c56fda9ea355c49fec07d5 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java 05a799ce09757ca8ed5338a465fae4477adec744 
> 
> Diff: https://reviews.apache.org/r/9896/diff/
> 
> 
> Testing
> -------
> 
> Integration tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request: SQOOP-946 Sqoop2: Integration: Enhance the POC test case

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9896/
-----------------------------------------------------------

(Updated March 17, 2013, 8:07 p.m.)


Review request for Sqoop.


Changes
-------

I've clean it up a bit more:

* I've removed some copy-pasted functionality into shared methods.
* I've changed the database provider to be a static variable so that it don't have to be reinitialized for each test case.


Description
-------

I've changed a bit the temporary path generation logic by appending method name as another directory to the path. The reasoning is to support test cases with multiple tests (each test will have it's own sandbox). I've also extracted few easily reusable methods and added new test.


This addresses bug SQOOP-946.
    https://issues.apache.org/jira/browse/SQOOP-946


Diffs (updated)
-----

  test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java 5631144f8f0575d7507055f70b42e9edfc762904 
  test/src/test/java/org/apache/sqoop/integration/connector/ConnectorTestCase.java 14f7dc42f30d86a9e7c56fda9ea355c49fec07d5 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java 05a799ce09757ca8ed5338a465fae4477adec744 

Diff: https://reviews.apache.org/r/9896/diff/


Testing
-------

Integration tests seems to be passing.


Thanks,

Jarek Cecho