You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shale.apache.org by "Craig McClanahan (JIRA)" <ji...@apache.org> on 2006/08/10 19:03:21 UTC
[jira] Created: (SHALE-249) Add "throws Exception" to signatures of
setUp() and tearDown() in AbstractJsfTestCase
Add "throws Exception" to signatures of setUp() and tearDown() in AbstractJsfTestCase
-------------------------------------------------------------------------------------
Key: SHALE-249
URL: http://issues.apache.org/struts/browse/SHALE-249
Project: Shale
Issue Type: Improvement
Components: Test
Reporter: Craig McClanahan
(From a discussion on the user mailing list <http://mail-archives.apache.org/mod_mbox/shale-user/200608.mbox/%3c4291B4B1A74DA74B8EB4F69433515F85068D2369@usahm233.amer.corp.eds.com%3e>)
In JUnit 3.8.1, the TestCase base class declares "throws Exception" in its method signatures for setUp() and tearDown(), but this is not the case on AbstractJsfTestCase. Should be added for consistency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SHALE-249) Add "throws Exception" to signatures
of setUp() and tearDown() in AbstractJsfTestCase
Posted by "Wendy Smoak (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-249?page=comments#action_37947 ]
Wendy Smoak commented on SHALE-249:
-----------------------------------
I'm with James -- if it's incorrect, lets fix it. We've only had an alpha release, people will understand that things may change.
> Add "throws Exception" to signatures of setUp() and tearDown() in AbstractJsfTestCase
> -------------------------------------------------------------------------------------
>
> Key: SHALE-249
> URL: http://issues.apache.org/struts/browse/SHALE-249
> Project: Shale
> Issue Type: Improvement
> Components: Test
> Reporter: Craig McClanahan
>
> (From a discussion on the user mailing list <http://mail-archives.apache.org/mod_mbox/shale-user/200608.mbox/%3c4291B4B1A74DA74B8EB4F69433515F85068D2369@usahm233.amer.corp.eds.com%3e>)
> In JUnit 3.8.1, the TestCase base class declares "throws Exception" in its method signatures for setUp() and tearDown(), but this is not the case on AbstractJsfTestCase. Should be added for consistency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SHALE-249) Add "throws Exception" to signatures
of setUp() and tearDown() in AbstractJsfTestCase
Posted by "Craig McClanahan (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-249?page=comments#action_37948 ]
Craig McClanahan commented on SHALE-249:
----------------------------------------
I'm sympathetic to the "get it right" group, but would like to make sure the MyFaces and Trinidad folks aren't going to come after us with a vengeance for breaking lots of their tests. :-)
Matthias/Sean: Any thoughts on what the impact would be?
> Add "throws Exception" to signatures of setUp() and tearDown() in AbstractJsfTestCase
> -------------------------------------------------------------------------------------
>
> Key: SHALE-249
> URL: http://issues.apache.org/struts/browse/SHALE-249
> Project: Shale
> Issue Type: Improvement
> Components: Test
> Reporter: Craig McClanahan
>
> (From a discussion on the user mailing list <http://mail-archives.apache.org/mod_mbox/shale-user/200608.mbox/%3c4291B4B1A74DA74B8EB4F69433515F85068D2369@usahm233.amer.corp.eds.com%3e>)
> In JUnit 3.8.1, the TestCase base class declares "throws Exception" in its method signatures for setUp() and tearDown(), but this is not the case on AbstractJsfTestCase. Should be added for consistency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SHALE-249) Add "throws Exception" to signatures
of setUp() and tearDown() in AbstractJsfTestCase
Posted by "James Mitchell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-249?page=comments#action_37945 ]
James Mitchell commented on SHALE-249:
--------------------------------------
I don't understand why we can't just change it now. If this were a key piece of the core library, sure, but this seems so minimal. I'd wager that most people using this test library have their own base extension and therefore would only require a change in one file.
I hate the Foo2 antipattern almost as much as I hate the FixForBug123Foo antipattern.
Just my $.02
> Add "throws Exception" to signatures of setUp() and tearDown() in AbstractJsfTestCase
> -------------------------------------------------------------------------------------
>
> Key: SHALE-249
> URL: http://issues.apache.org/struts/browse/SHALE-249
> Project: Shale
> Issue Type: Improvement
> Components: Test
> Reporter: Craig McClanahan
>
> (From a discussion on the user mailing list <http://mail-archives.apache.org/mod_mbox/shale-user/200608.mbox/%3c4291B4B1A74DA74B8EB4F69433515F85068D2369@usahm233.amer.corp.eds.com%3e>)
> In JUnit 3.8.1, the TestCase base class declares "throws Exception" in its method signatures for setUp() and tearDown(), but this is not the case on AbstractJsfTestCase. Should be added for consistency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SHALE-249) Add "throws Exception" to signatures
of setUp() and tearDown() in AbstractJsfTestCase
Posted by "sean schofield (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-249?page=comments#action_37985 ]
sean schofield commented on SHALE-249:
--------------------------------------
You will also need to change the setUp and tearDown methods in your test cases from protected to public.
> Add "throws Exception" to signatures of setUp() and tearDown() in AbstractJsfTestCase
> -------------------------------------------------------------------------------------
>
> Key: SHALE-249
> URL: http://issues.apache.org/struts/browse/SHALE-249
> Project: Shale
> Issue Type: Improvement
> Components: Test
> Reporter: Craig McClanahan
> Assigned To: Craig McClanahan
> Fix For: 1.0.3-SNAPSHOT
>
>
> (From a discussion on the user mailing list <http://mail-archives.apache.org/mod_mbox/shale-user/200608.mbox/%3c4291B4B1A74DA74B8EB4F69433515F85068D2369@usahm233.amer.corp.eds.com%3e>)
> In JUnit 3.8.1, the TestCase base class declares "throws Exception" in its method signatures for setUp() and tearDown(), but this is not the case on AbstractJsfTestCase. Should be added for consistency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SHALE-249) Add "throws Exception" to signatures
of setUp() and tearDown() in AbstractJsfTestCase
Posted by "Craig McClanahan (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-249?page=comments#action_37942 ]
Craig McClanahan commented on SHALE-249:
----------------------------------------
Adding this would break existing test cases that don't already declare the throws clauses on these two methods. So, we should also consider other alternatives (perhaps something like AbstractJsfTestCase2 that extends AbstradJsfTestCase and just adds these signature changes).
> Add "throws Exception" to signatures of setUp() and tearDown() in AbstractJsfTestCase
> -------------------------------------------------------------------------------------
>
> Key: SHALE-249
> URL: http://issues.apache.org/struts/browse/SHALE-249
> Project: Shale
> Issue Type: Improvement
> Components: Test
> Reporter: Craig McClanahan
>
> (From a discussion on the user mailing list <http://mail-archives.apache.org/mod_mbox/shale-user/200608.mbox/%3c4291B4B1A74DA74B8EB4F69433515F85068D2369@usahm233.amer.corp.eds.com%3e>)
> In JUnit 3.8.1, the TestCase base class declares "throws Exception" in its method signatures for setUp() and tearDown(), but this is not the case on AbstractJsfTestCase. Should be added for consistency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SHALE-249) Add "throws Exception" to signatures
of setUp() and tearDown() in AbstractJsfTestCase
Posted by "Craig McClanahan (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-249?page=comments#action_37950 ]
Craig McClanahan commented on SHALE-249:
----------------------------------------
I got agreement with the MyFaces folks on going ahead with this ('course they didn't squawk when I volunteered to fix the tests it broke too).
> Add "throws Exception" to signatures of setUp() and tearDown() in AbstractJsfTestCase
> -------------------------------------------------------------------------------------
>
> Key: SHALE-249
> URL: http://issues.apache.org/struts/browse/SHALE-249
> Project: Shale
> Issue Type: Improvement
> Components: Test
> Reporter: Craig McClanahan
> Assigned To: Craig McClanahan
>
> (From a discussion on the user mailing list <http://mail-archives.apache.org/mod_mbox/shale-user/200608.mbox/%3c4291B4B1A74DA74B8EB4F69433515F85068D2369@usahm233.amer.corp.eds.com%3e>)
> In JUnit 3.8.1, the TestCase base class declares "throws Exception" in its method signatures for setUp() and tearDown(), but this is not the case on AbstractJsfTestCase. Should be added for consistency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (SHALE-249) Add "throws Exception" to
signatures of setUp() and tearDown() in AbstractJsfTestCase
Posted by "Craig McClanahan (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-249?page=all ]
Work on SHALE-249 started by Craig McClanahan.
> Add "throws Exception" to signatures of setUp() and tearDown() in AbstractJsfTestCase
> -------------------------------------------------------------------------------------
>
> Key: SHALE-249
> URL: http://issues.apache.org/struts/browse/SHALE-249
> Project: Shale
> Issue Type: Improvement
> Components: Test
> Reporter: Craig McClanahan
> Assigned To: Craig McClanahan
>
> (From a discussion on the user mailing list <http://mail-archives.apache.org/mod_mbox/shale-user/200608.mbox/%3c4291B4B1A74DA74B8EB4F69433515F85068D2369@usahm233.amer.corp.eds.com%3e>)
> In JUnit 3.8.1, the TestCase base class declares "throws Exception" in its method signatures for setUp() and tearDown(), but this is not the case on AbstractJsfTestCase. Should be added for consistency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SHALE-249) Add "throws Exception" to signatures
of setUp() and tearDown() in AbstractJsfTestCase
Posted by "Craig McClanahan (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-249?page=all ]
Craig McClanahan resolved SHALE-249.
------------------------------------
Fix Version/s: 1.0.3-SNAPSHOT
Resolution: Fixed
Fixed in nightly build 20060812. Will be included in 1.0.3 release.
WARNING: This change will create breakage if you have unit tests that extend AbstractJsfTextCase ... you will need to add "throws Exception" on each of these methods to successfully compile. Normally, I don't like making this kind of incompatible change, but it's really now or never for a 1.x Shale release, and this one is important.
> Add "throws Exception" to signatures of setUp() and tearDown() in AbstractJsfTestCase
> -------------------------------------------------------------------------------------
>
> Key: SHALE-249
> URL: http://issues.apache.org/struts/browse/SHALE-249
> Project: Shale
> Issue Type: Improvement
> Components: Test
> Reporter: Craig McClanahan
> Assigned To: Craig McClanahan
> Fix For: 1.0.3-SNAPSHOT
>
>
> (From a discussion on the user mailing list <http://mail-archives.apache.org/mod_mbox/shale-user/200608.mbox/%3c4291B4B1A74DA74B8EB4F69433515F85068D2369@usahm233.amer.corp.eds.com%3e>)
> In JUnit 3.8.1, the TestCase base class declares "throws Exception" in its method signatures for setUp() and tearDown(), but this is not the case on AbstractJsfTestCase. Should be added for consistency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (SHALE-249) Add "throws Exception" to signatures
of setUp() and tearDown() in AbstractJsfTestCase
Posted by "Craig McClanahan (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SHALE-249?page=all ]
Craig McClanahan reassigned SHALE-249:
--------------------------------------
Assignee: Craig McClanahan
> Add "throws Exception" to signatures of setUp() and tearDown() in AbstractJsfTestCase
> -------------------------------------------------------------------------------------
>
> Key: SHALE-249
> URL: http://issues.apache.org/struts/browse/SHALE-249
> Project: Shale
> Issue Type: Improvement
> Components: Test
> Reporter: Craig McClanahan
> Assigned To: Craig McClanahan
>
> (From a discussion on the user mailing list <http://mail-archives.apache.org/mod_mbox/shale-user/200608.mbox/%3c4291B4B1A74DA74B8EB4F69433515F85068D2369@usahm233.amer.corp.eds.com%3e>)
> In JUnit 3.8.1, the TestCase base class declares "throws Exception" in its method signatures for setUp() and tearDown(), but this is not the case on AbstractJsfTestCase. Should be added for consistency.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira