You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/19 08:35:23 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4582: Upgrade: check systemvm template before db changes
ustcweizhou opened a new pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582
### Description
Currently in upgrade cloudstack checks the systemvm template after db changes.
if user do not install systemvm template and uprgade cloudstack (for example install packages with newer version), upgrade will fail. in this case it will be very complicated to rollback the db if there is no db backup.
This pr checks the latest (only the last) systemvm template in upgrade path, and exits if required systemvm template is not registered.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [X] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-771610117
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2636
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-758570678
@ustcweizhou isn't the whole db upgrade path wrapped in a transaction? I suppose the whole transaction would fail without committing anything to the DB?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-784115943
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ustcweizhou closed pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
ustcweizhou closed pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-783251706
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-766683652
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#discussion_r567691407
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
##########
@@ -232,11 +233,41 @@ protected void runScript(Connection conn, InputStream file) {
}
+ private void updateSystemVmTemplates(DbUpgrade[] upgrades) {
+ for (int i = upgrades.length - 1; i >= 0; i--) {
+ DbUpgrade upgrade = upgrades[i];
+ if (upgrade instanceof DbUpgradeSystemVmTemplate) {
+ TransactionLegacy txn = TransactionLegacy.open("Upgrade");
+ txn.start();
+ try {
+ Connection conn;
+ try {
+ conn = txn.getConnection();
+ } catch (SQLException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ }
+ ((DbUpgradeSystemVmTemplate)upgrade).updateSystemVmTemplates(conn);
+ break;
+ } catch (CloudRuntimeException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ } finally {
+ txn.close();
Review comment:
@ustcweizhou I believe there's a need to do a txn.commit() before closing the transaction as the DB changes made as part of the updateSystemVmTemplate() gets rolled back
```
Rolling back the transaction: Time = 22 Name = Upgrade; called by -TransactionLegacy.rollback:888-TransactionLegacy.removeUpTo:831-TransactionLegacy.close:655-DatabaseUpgradeChecker.updateSystemVmTemplates:264-DatabaseUpgradeChecker.upgrade:275-DatabaseUpgradeChecker.check:379-CloudStackExtendedLifeCycle.checkIntegrity:64-CloudStackExtendedLifeCycle.start:54-DefaultLifecycleProcessor.doStart:182-DefaultLifecycleProcessor.access$200:53-DefaultLifecycleProcessor$LifecycleGroup.start:360-DefaultLifecycleProcessor.startBeans:158
2021-02-01 09:50:57,795 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41500to41510 to upgrade from 4.15.0.0-4.15.1.0 to 4.15.1.0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-784149892
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-783277797
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ustcweizhou commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
ustcweizhou commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-758554332
@davidjumani @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-771540433
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-766683652
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-762695886
> test proposal:
>
> 1. don't upload templates,
> 2. upgrade,
> 3. start,
> 4. stop,
> 5. downgrade,
> 6. start,
> 7. upload templates,
> 8. stop,
> 9. start.
> agree?
@DaanHoogland yes, exactly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#discussion_r567712717
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
##########
@@ -232,11 +233,41 @@ protected void runScript(Connection conn, InputStream file) {
}
+ private void updateSystemVmTemplates(DbUpgrade[] upgrades) {
+ for (int i = upgrades.length - 1; i >= 0; i--) {
+ DbUpgrade upgrade = upgrades[i];
+ if (upgrade instanceof DbUpgradeSystemVmTemplate) {
+ TransactionLegacy txn = TransactionLegacy.open("Upgrade");
+ txn.start();
+ try {
+ Connection conn;
+ try {
+ conn = txn.getConnection();
+ } catch (SQLException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ }
+ ((DbUpgradeSystemVmTemplate)upgrade).updateSystemVmTemplates(conn);
+ break;
+ } catch (CloudRuntimeException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ } finally {
+ txn.close();
Review comment:
@weizhouapache I tested this by merging this code to master. However, the steps are equivalent to :
1. Deploy a 4.14 env
2. Register the template (4.15 template)
3. upgrade to 4.15
4. The Management server comes up fine, but, if we check the cloud.configuration value (in the DB) for attribute - "router.template.<hypervisor>" notice it doesn't update the template name to the new one.
The case of not applying the DB changes when template isn't registered, works absolutely fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-766684474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-767375855
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#discussion_r568469930
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
##########
@@ -232,11 +233,41 @@ protected void runScript(Connection conn, InputStream file) {
}
+ private void updateSystemVmTemplates(DbUpgrade[] upgrades) {
+ for (int i = upgrades.length - 1; i >= 0; i--) {
+ DbUpgrade upgrade = upgrades[i];
+ if (upgrade instanceof DbUpgradeSystemVmTemplate) {
+ TransactionLegacy txn = TransactionLegacy.open("Upgrade");
+ txn.start();
+ try {
+ Connection conn;
+ try {
+ conn = txn.getConnection();
+ } catch (SQLException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ }
+ ((DbUpgradeSystemVmTemplate)upgrade).updateSystemVmTemplates(conn);
+ break;
+ } catch (CloudRuntimeException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ } finally {
+ txn.close();
Review comment:
@Pearl1594 yeah, you are right !
pushed a change.
thanks for review and testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-771540433
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-782017913
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-771590605
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-783277797
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-767375404
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-762696073
@DaanHoogland @rhtyd
can you kick off trillian test ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-771590023
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-758624837
> @ustcweizhou isn't the whole db upgrade path wrapped in a transaction? I suppose the whole transaction would fail without committing anything to the DB?
@rhtyd
unfortunately no...
In each upgrade, the transaction will be started, committed and finally closed.
https://github.com/apache/cloudstack/blob/master/engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java#L240-L310
it is bad, but not the worst.
new system template is checked in performMigration. Before that, sql in script will be committed
(1) autocommit is true.
in https://github.com/apache/cloudstack/blob/master/framework/db/src/main/java/com/cloud/utils/db/ScriptRunner.java#L148-L150
(2) autocommit is false.
https://github.com/apache/cloudstack/blob/master/framework/db/src/main/java/com/cloud/utils/db/ScriptRunner.java#L181-L183
options are
(1) check systemvm template at the beginning of whole upgrade, or
(2) check systemvm template at each version upgrade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-784606536
<b>Trillian test result (tid-3608)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32793 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4582-t3608-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#discussion_r560006121
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
##########
@@ -237,6 +238,32 @@ protected void upgrade(CloudStackVersion dbVersion, CloudStackVersion currentVer
final DbUpgrade[] upgrades = calculateUpgradePath(dbVersion, currentVersion);
+ for (int i = upgrades.length - 1; i >= 0; i--) {
+ DbUpgrade upgrade = upgrades[i];
+ if (upgrade instanceof DbUpgradeSystemVmTemplate) {
+ TransactionLegacy txn = TransactionLegacy.open("Upgrade");
+ txn.start();
+ try {
+ Connection conn;
+ try {
+ conn = txn.getConnection();
+ } catch (SQLException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ }
+ ((DbUpgradeSystemVmTemplate)upgrade).updateSystemVmTemplates(conn);
+ break;
+ } catch (CloudRuntimeException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ } finally {
+ txn.close();
+ }
+ }
+ }
Review comment:
@DaanHoogland yes, done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-771572431
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2630
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-767413100
jenkins build failed at point below. close/open this pr to retry.
```
[INFO] --< org.apache.cloudstack:cloud-plugin-integrations-cloudian-connector >--
[INFO] Building Apache CloudStack Plugin - Cloudian Connector 4.15.1.0-SNAPSHOT [74/116]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.0:check (cloudstack-checkstyle) @ cloud-plugin-integrations-cloudian-connector ---
[INFO] Starting audit...
Audit done.
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.3:prepare-agent (prepare-coverage-agent) @ cloud-plugin-integrations-cloudian-connector ---
[INFO] argLine set to -javaagent:/home/jenkins/.m2/repository/org/jacoco/org.jacoco.agent/0.8.3/org.jacoco.agent-0.8.3-runtime.jar=destfile=/home/jenkins/jenkins-agent/workspace/Cloudstack/cloudstack-pr-analysis/plugins/integrations/cloudian/target/jacoco.exec
[INFO]
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-plugin-integrations-cloudian-connector ---
[INFO]
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ cloud-plugin-integrations-cloudian-connector ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ cloud-plugin-integrations-cloudian-connector ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 10 source files to /home/jenkins/jenkins-agent/workspace/Cloudstack/cloudstack-pr-analysis/plugins/integrations/cloudian/target/classes
[INFO]
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ cloud-plugin-integrations-cloudian-connector ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /home/jenkins/jenkins-agent/workspace/Cloudstack/cloudstack-pr-analysis/plugins/integrations/cloudian/src/test/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ cloud-plugin-integrations-cloudian-connector ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 1 source file to /home/jenkins/jenkins-agent/workspace/Cloudstack/cloudstack-pr-analysis/plugins/integrations/cloudian/target/test-classes
[INFO]
[INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ cloud-plugin-integrations-cloudian-connector ---
[INFO]
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.cloudstack.cloudian.CloudianClientTest
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
log4j:WARN No appenders could be found for logger (org.apache.cloudstack.cloudian.client.CloudianClient).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
[ERROR] Tests run: 25, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.1 s <<< FAILURE! - in org.apache.cloudstack.cloudian.CloudianClientTest
[ERROR] addUserAccountFail(org.apache.cloudstack.cloudian.CloudianClientTest) Time elapsed: 5.447 s <<< ERROR!
org.apache.cloudstack.api.ServerApiException: Operation timed out, please try again.
at org.apache.cloudstack.cloudian.CloudianClientTest.addUserAccountFail(CloudianClientTest.java:145)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] CloudianClientTest.addUserAccountFail:145 » ServerApi Operation timed out, ple...
[INFO]
[ERROR] Tests run: 25, Failures: 0, Errors: 1, Skipped: 0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#discussion_r581860066
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41400to41500.java
##########
@@ -67,12 +67,12 @@ public boolean supportsRollingUpgrade() {
@Override
public void performDataMigration(Connection conn) {
- updateSystemVmTemplates(conn);
Review comment:
+1 important thing to remember now is not to run this again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-771590023
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-784116541
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-784025488
Packaging result: ✖centos7 ✔centos8 ✔debian. JID-2807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#discussion_r559766076
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
##########
@@ -237,6 +238,32 @@ protected void upgrade(CloudStackVersion dbVersion, CloudStackVersion currentVer
final DbUpgrade[] upgrades = calculateUpgradePath(dbVersion, currentVersion);
+ for (int i = upgrades.length - 1; i >= 0; i--) {
+ DbUpgrade upgrade = upgrades[i];
+ if (upgrade instanceof DbUpgradeSystemVmTemplate) {
+ TransactionLegacy txn = TransactionLegacy.open("Upgrade");
+ txn.start();
+ try {
+ Connection conn;
+ try {
+ conn = txn.getConnection();
+ } catch (SQLException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ }
+ ((DbUpgradeSystemVmTemplate)upgrade).updateSystemVmTemplates(conn);
+ break;
+ } catch (CloudRuntimeException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ } finally {
+ txn.close();
+ }
+ }
+ }
Review comment:
can we put this in a separate method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-771541460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#discussion_r567691407
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
##########
@@ -232,11 +233,41 @@ protected void runScript(Connection conn, InputStream file) {
}
+ private void updateSystemVmTemplates(DbUpgrade[] upgrades) {
+ for (int i = upgrades.length - 1; i >= 0; i--) {
+ DbUpgrade upgrade = upgrades[i];
+ if (upgrade instanceof DbUpgradeSystemVmTemplate) {
+ TransactionLegacy txn = TransactionLegacy.open("Upgrade");
+ txn.start();
+ try {
+ Connection conn;
+ try {
+ conn = txn.getConnection();
+ } catch (SQLException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ }
+ ((DbUpgradeSystemVmTemplate)upgrade).updateSystemVmTemplates(conn);
+ break;
+ } catch (CloudRuntimeException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ } finally {
+ txn.close();
Review comment:
@weizhouapache I believe there's a need to do a txn.commit() before closing the transaction as the DB changes made as part of the updateSystemVmTemplate() gets rolled back
```
Rolling back the transaction: Time = 22 Name = Upgrade; called by -TransactionLegacy.rollback:888-TransactionLegacy.removeUpTo:831-TransactionLegacy.close:655-DatabaseUpgradeChecker.updateSystemVmTemplates:264-DatabaseUpgradeChecker.upgrade:275-DatabaseUpgradeChecker.check:379-CloudStackExtendedLifeCycle.checkIntegrity:64-CloudStackExtendedLifeCycle.start:54-DefaultLifecycleProcessor.doStart:182-DefaultLifecycleProcessor.access$200:53-DefaultLifecycleProcessor$LifecycleGroup.start:360-DefaultLifecycleProcessor.startBeans:158
2021-02-01 09:50:57,795 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41500to41510 to upgrade from 4.15.0.0-4.15.1.0 to 4.15.1.0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-766684474
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-784215240
I think we don't need this as the upgrade was tested manually by @Pearl1594 . better safe though
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-762440648
test proposal:
1. don't upload templates,
2. upgrade,
3. start,
4. stop,
5. downgrade,
6. start,
7. upload templates,
8. stop,
9. start.
agree?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-783252388
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-781937729
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-781937080
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#discussion_r568469930
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
##########
@@ -232,11 +233,41 @@ protected void runScript(Connection conn, InputStream file) {
}
+ private void updateSystemVmTemplates(DbUpgrade[] upgrades) {
+ for (int i = upgrades.length - 1; i >= 0; i--) {
+ DbUpgrade upgrade = upgrades[i];
+ if (upgrade instanceof DbUpgradeSystemVmTemplate) {
+ TransactionLegacy txn = TransactionLegacy.open("Upgrade");
+ txn.start();
+ try {
+ Connection conn;
+ try {
+ conn = txn.getConnection();
+ } catch (SQLException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ }
+ ((DbUpgradeSystemVmTemplate)upgrade).updateSystemVmTemplates(conn);
+ break;
+ } catch (CloudRuntimeException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ } finally {
+ txn.close();
Review comment:
@Pearl1594 yeah, you are right !
pushed a change.
thanks for review and testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#discussion_r567708383
##########
File path: engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
##########
@@ -232,11 +233,41 @@ protected void runScript(Connection conn, InputStream file) {
}
+ private void updateSystemVmTemplates(DbUpgrade[] upgrades) {
+ for (int i = upgrades.length - 1; i >= 0; i--) {
+ DbUpgrade upgrade = upgrades[i];
+ if (upgrade instanceof DbUpgradeSystemVmTemplate) {
+ TransactionLegacy txn = TransactionLegacy.open("Upgrade");
+ txn.start();
+ try {
+ Connection conn;
+ try {
+ conn = txn.getConnection();
+ } catch (SQLException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ }
+ ((DbUpgradeSystemVmTemplate)upgrade).updateSystemVmTemplates(conn);
+ break;
+ } catch (CloudRuntimeException e) {
+ String errorMessage = "Unable to upgrade the database";
+ s_logger.error(errorMessage, e);
+ throw new CloudRuntimeException(errorMessage, e);
+ } finally {
+ txn.close();
Review comment:
> @ustcweizhou I believe there's a need to do a txn.commit() before closing the transaction as the DB changes made as part of the updateSystemVmTemplate() gets rolled back
>
> ```
> Rolling back the transaction: Time = 22 Name = Upgrade; called by -TransactionLegacy.rollback:888-TransactionLegacy.removeUpTo:831-TransactionLegacy.close:655-DatabaseUpgradeChecker.updateSystemVmTemplates:264-DatabaseUpgradeChecker.upgrade:275-DatabaseUpgradeChecker.check:379-CloudStackExtendedLifeCycle.checkIntegrity:64-CloudStackExtendedLifeCycle.start:54-DefaultLifecycleProcessor.doStart:182-DefaultLifecycleProcessor.access$200:53-DefaultLifecycleProcessor$LifecycleGroup.start:360-DefaultLifecycleProcessor.startBeans:158
> 2021-02-01 09:50:57,795 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Running upgrade Upgrade41500to41510 to upgrade from 4.15.0.0-4.15.1.0 to 4.15.1.0
> ```
@Pearl1594 thanks for testing.
could you tell how to reproduce the issue ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-784216017
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-766723927
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-771541460
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4582:
URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-767758927
<b>Trillian test result (tid-3413)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37454 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4582-t3413-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org