You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/10/29 16:52:40 UTC

[Impala-ASF-CR] IMPALA-10302: Enable logging at the INFO level for test scanners fuzz.py

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16677


Change subject: IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py
......................................................................

IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py

This changes test_scanners_fuzz.py to set the logging level
to INFO. By default, it is WARNING, so it was missing some useful
INFO log messages like the random seed used. This also fixes formatting
on one of the log lines.

Testing:
 - Ran test_scanners_fuzz.py locally and checked to make
   sure the INFO messages were present

Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/16677/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
Gerrit-Change-Number: 16677
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10302: Enable logging at the INFO level for test scanners fuzz.py

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16677 )

Change subject: IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
Gerrit-Change-Number: 16677
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Oct 2020 17:43:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10302: Enable logging at the INFO level for test scanners fuzz.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16677 )

Change subject: IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
Gerrit-Change-Number: 16677
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Oct 2020 03:25:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10302: Enable logging at the INFO level for test scanners fuzz.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16677 )

Change subject: IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6617/


-- 
To view, visit http://gerrit.cloudera.org:8080/16677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
Gerrit-Change-Number: 16677
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Oct 2020 21:58:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10302: Enable logging at the INFO level for test scanners fuzz.py

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16677 )

Change subject: IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py
......................................................................

IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py

This changes test_scanners_fuzz.py to set the logging level
to INFO. By default, it is WARNING, so it was missing some useful
INFO log messages like the random seed used. This also fixes formatting
on one of the log lines.

Testing:
 - Ran test_scanners_fuzz.py locally and checked to make
   sure the INFO messages were present

Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
Reviewed-on: http://gerrit.cloudera.org:8080/16677
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
Gerrit-Change-Number: 16677
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-10302: Enable logging at the INFO level for test scanners fuzz.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16677 )

Change subject: IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7579/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
Gerrit-Change-Number: 16677
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Oct 2020 17:15:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10302: Enable logging at the INFO level for test scanners fuzz.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16677 )

Change subject: IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6621/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/16677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
Gerrit-Change-Number: 16677
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Oct 2020 22:01:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10302: Enable logging at the INFO level for test scanners fuzz.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16677 )

Change subject: IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
Gerrit-Change-Number: 16677
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Oct 2020 17:46:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10302: Enable logging at the INFO level for test scanners fuzz.py

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16677 )

Change subject: IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py
......................................................................


Patch Set 2:

Test failure is a dataload issue unrelated to this change. Retrying


-- 
To view, visit http://gerrit.cloudera.org:8080/16677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
Gerrit-Change-Number: 16677
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Oct 2020 22:01:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10302: Enable logging at the INFO level for test scanners fuzz.py

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16677 )

Change subject: IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py
......................................................................


Patch Set 1: Code-Review+1

Looks good!


-- 
To view, visit http://gerrit.cloudera.org:8080/16677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
Gerrit-Change-Number: 16677
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Oct 2020 17:26:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10302: Enable logging at the INFO level for test scanners fuzz.py

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16677 )

Change subject: IMPALA-10302: Enable logging at the INFO level for test_scanners_fuzz.py
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6617/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida4a9cbed6572520998def9618a8b4189c1ba799
Gerrit-Change-Number: 16677
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Oct 2020 17:46:17 +0000
Gerrit-HasComments: No