You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/30 01:39:09 UTC
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1677: Adjust dependencies of cloud and distribution
TeslaCN opened a new pull request #1677:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1677
Fixes #1676
Changes proposed in this pull request:
- Add modules under elasticjob-error-handler-type to lite distribution.
- Add elasticjob-http-executor to module elasticjob-cloud-common.
- Inherit version of http-client from dependencyManagement.
- Remove unused properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1677: Adjust dependencies of cloud and distribution
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1677:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1677#issuecomment-719120336
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=h1) Report
> Merging [#1677](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/065856b9a8bf122452d442c35274c2596beeece9?el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1677 +/- ##
============================================
- Coverage 86.10% 86.01% -0.09%
Complexity 105 105
============================================
Files 251 251
Lines 5677 5677
Branches 875 875
============================================
- Hits 4888 4883 -5
- Misses 476 477 +1
- Partials 313 317 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
| [...ite/internal/election/ElectionListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZWxlY3Rpb24vRWxlY3Rpb25MaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `92.00% <0.00%> (-4.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (-1.59%)` | `1.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=footer). Last update [065856b...cfea5fa](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1677: Adjust dependencies of cloud and distribution
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1677:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1677
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1677: Adjust dependencies of cloud and distribution
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1677:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1677#issuecomment-719120336
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=h1) Report
> Merging [#1677](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/065856b9a8bf122452d442c35274c2596beeece9?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1677 +/- ##
============================================
- Coverage 86.10% 86.08% -0.02%
Complexity 105 105
============================================
Files 251 251
Lines 5677 5677
Branches 875 875
============================================
- Hits 4888 4887 -1
Misses 476 476
- Partials 313 314 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (-1.59%)` | `1.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=footer). Last update [065856b...cfea5fa](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1677?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org