You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2018/11/19 14:52:27 UTC
[GitHub] carbondata pull request #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the er...
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2929
[CARBONDATA-3108][CARBONDATA-3044] Fix the error of jvm will crash when CarbonRow use wrong index number in CSDK
This PR:
1. fix the error of jvm will crash when CarbonRow use wrong index number in CSDK
including getString, getVarchar, getArray, getDecimal
2. delete/release the data after running
3. init the variable to NULL
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
No
- [ ] Any backward compatibility impacted?
No
- [ ] Document update required?
Yes
- [ ] Testing done
add
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
JIRA2951
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata CARBONDATA-3108_CarbonRowJvmCrash
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2929.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2929
----
commit 1f72221db80eafa82addb092414f7cc072a110c6
Author: xubo245 <xu...@...>
Date: 2018-11-19T14:48:31Z
[CARBONDATA-3108][CARBONDATA-3044] Fix the error of jvm will crash when CarbonRow use wrong index number in CSDK
1. fix the error
2. delete/release the data after running
3. init the variable to NULL
----
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2929
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9711/
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2929
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9745/
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2929
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1453/
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2929
@KanakaKumar @kunal642 CI pass, please check it.
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2929
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9733/
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by KanakaKumar <gi...@git.apache.org>.
Github user KanakaKumar commented on the issue:
https://github.com/apache/carbondata/pull/2929
LGTM
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2929
retest this please
---
[GitHub] carbondata pull request #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the er...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2929#discussion_r235266305
--- Diff: store/CSDK/src/CarbonRow.cpp ---
@@ -170,6 +170,9 @@ char *CarbonRow::getString(int ordinal) {
args[0].l = carbonRow;
args[1].i = ordinal;
jobject data = jniEnv->CallStaticObjectMethodA(rowUtilClass, getStringId, args);
+ if (jniEnv->ExceptionCheck()) {
--- End diff --
1. done, please check again.
2.no need create new jvm, it can be used again after catch. In the test case, I use one jvm and try catch exception in the first test case: tryCarbonRowException. testCarbonProperties is running after try catch.
```
tryCatchException(env);
tryCarbonRowException(env, smallFilePath);
testCarbonProperties(env);
testWriteData(env, "./data", 1, argv);
```
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2929
@xubo245 Please resolve the conflicts
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2929
@KanakaKumar @brijoobopanna @BJangir @jackylk @ajantha-bhat @kunal642 Please review it.
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2929
@kunal642 Rebased.
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2929
LGTM
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2929
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1685/
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2929
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1480/
---
[GitHub] carbondata pull request #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the er...
Posted by KanakaKumar <gi...@git.apache.org>.
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2929#discussion_r235261186
--- Diff: store/CSDK/src/CarbonRow.cpp ---
@@ -170,6 +170,9 @@ char *CarbonRow::getString(int ordinal) {
args[0].l = carbonRow;
args[1].i = ordinal;
jobject data = jniEnv->CallStaticObjectMethodA(rowUtilClass, getStringId, args);
+ if (jniEnv->ExceptionCheck()) {
--- End diff --
Exception check should be done for all other method calls also like getBoolean, getFloat,etc.
ArrayIndexOutofBoundsException on wrong index & cast exceptions on wrong method usage are possible
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2929
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1475/
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2929
@kunal642 @KanakaKumar Rebased, CI pass, please check it.
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2929
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1663/
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2929
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1487/
---
[GitHub] carbondata pull request #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the er...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2929
---
[GitHub] carbondata pull request #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the er...
Posted by KanakaKumar <gi...@git.apache.org>.
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2929#discussion_r235266810
--- Diff: store/CSDK/src/CarbonRow.cpp ---
@@ -170,6 +170,9 @@ char *CarbonRow::getString(int ordinal) {
args[0].l = carbonRow;
args[1].i = ordinal;
jobject data = jniEnv->CallStaticObjectMethodA(rowUtilClass, getStringId, args);
+ if (jniEnv->ExceptionCheck()) {
--- End diff --
ok
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2929
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9738/
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2929
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1690/
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2929
@KanakaKumar @brijoobopanna @BJangir @jackylk Please review it.
---
[GitHub] carbondata issue #2929: [CARBONDATA-3108][CARBONDATA-3044] Fix the error of ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2929
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1697/
---