You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/01/31 18:02:59 UTC

[GitHub] [pinot] richardstartin opened a new pull request #8097: fix FST Like query benchmark to remove SQL parsing from the measurement

richardstartin opened a new pull request #8097:
URL: https://github.com/apache/pinot/pull/8097


   I noticed that the FST Like benchmark results vary a lot:
   
   ```
   Benchmark                                                 Mode  Cnt  Score   Error  Units
   BenchmarkNativeAndLuceneBasedLike.testLuceneBasedFSTLike  avgt   25  3.127 ± 0.578   s/op
   BenchmarkNativeAndLuceneBasedLike.testNativeBasedFSTLike  avgt   25  3.440 ± 0.555   s/op
   ```
   
   When running these benchmarks with `-prof jfr` to figure out what they were actually measuring I noticed a couple of things:
   
   1. Most of the time is spent parsing SQL creating the query context
   <img width="1530" alt="Screenshot 2022-01-31 at 17 54 48" src="https://user-images.githubusercontent.com/16439049/151846946-0b3aa09b-a0ba-43bb-af13-a120406e311e.png">
   2. Because the benchmark doesn't properly segregate the FST types or clean up after itself properly (it uses a testng `AfterClass` annotation which JMH doesn't know anything about), the `testNativeBasedFSTLike` sometimes measures the Lucene implementation, but when it does measure the Native implementation, the SQL parsing frames are much narrower relative to the construction of the filter operator.
   
   <img width="1546" alt="Screenshot 2022-01-31 at 17 58 54" src="https://user-images.githubusercontent.com/16439049/151847574-9073b823-d2ea-4f03-82c8-84e33aca94e2.png">
   
   After a couple of changes to use proper JMH lifecycle and to factor out SQL parsing into the setup, most of the benchmark time is spent in construction of the filter operator:
   
   Lucene:
   <img width="1509" alt="Screenshot 2022-01-31 at 17 48 12" src="https://user-images.githubusercontent.com/16439049/151845914-9b5440f8-c643-43e1-b873-6fd2e031fcbd.png">
   Native:
   <img width="1540" alt="Screenshot 2022-01-31 at 17 48 48" src="https://user-images.githubusercontent.com/16439049/151846014-a8d5cd66-d61d-419d-8f5e-d0c72807dc4d.png">
   
   The results are more stable and tell a different story, which should help drive future improvement in this space:
   
   ```
   Benchmark                                (_fstType)  (_intBaseValue)  (_numRows)                                                                 (_query)  Mode  Cnt    Score    Error  Units
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt   25   65.626 ±  1.454  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt   25  232.908 ± 17.302  us/op
   ```
   
   Future improvements may include iterating over more than one block.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] atris commented on pull request #8097: fix FST Like query benchmark to remove SQL parsing from the measurement

Posted by GitBox <gi...@apache.org>.
atris commented on pull request #8097:
URL: https://github.com/apache/pinot/pull/8097#issuecomment-1046561970


   > I'm going to go ahead and merge this.
   
   Thanks for this, @richardstartin . I have been swamped at work so couldn't take a look. I will investigate and update on your findings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] atris commented on pull request #8097: fix FST Like query benchmark to remove SQL parsing from the measurement

Posted by GitBox <gi...@apache.org>.
atris commented on pull request #8097:
URL: https://github.com/apache/pinot/pull/8097#issuecomment-1026136438


   Thanks for the tag, I will take a look tomorrow 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] codecov-commenter commented on pull request #8097: fix FST Like query benchmark to remove SQL parsing from the measurement

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8097:
URL: https://github.com/apache/pinot/pull/8097#issuecomment-1026215800


   # [Codecov](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8097](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af0c74d) into [master](https://codecov.io/gh/apache/pinot/commit/3f11902d3f570ef6d3a9c0eeb6504f911e039256?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f11902) will **decrease** coverage by `56.99%`.
   > The diff coverage is `2.47%`.
   
   > :exclamation: Current head af0c74d differs from pull request most recent head 8df9f57. Consider uploading reports for the commit 8df9f57 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/pinot/pull/8097/graphs/tree.svg?width=650&height=150&src=pr&token=4ibza2ugkz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #8097       +/-   ##
   =============================================
   - Coverage     71.21%   14.21%   -57.00%     
   + Complexity     4263       81     -4182     
   =============================================
     Files          1607     1572       -35     
     Lines         83409    81919     -1490     
     Branches      12458    12313      -145     
   =============================================
   - Hits          59397    11644    -47753     
   - Misses        19972    69415    +49443     
   + Partials       4040      860     -3180     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | integration1 | `?` | |
   | integration2 | `?` | |
   | unittests1 | `?` | |
   | unittests2 | `14.21% <2.47%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../pinot/core/data/manager/BaseTableDataManager.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvQmFzZVRhYmxlRGF0YU1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (-86.59%)` | :arrow_down: |
   | [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvTExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `0.00% <0.00%> (-71.08%)` | :arrow_down: |
   | [...nager/realtime/RealtimeConsumptionRateManager.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVDb25zdW1wdGlvblJhdGVNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/pinot/core/operator/blocks/FilterBlock.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvRmlsdGVyQmxvY2suamF2YQ==) | `0.00% <0.00%> (-57.15%)` | :arrow_down: |
   | [.../pinot/core/operator/docidsets/BitmapDocIdSet.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvQml0bWFwRG9jSWRTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t/core/operator/docidsets/FilterBlockDocIdSet.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvRmlsdGVyQmxvY2tEb2NJZFNldC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...re/operator/docidsets/RangelessBitmapDocIdSet.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvUmFuZ2VsZXNzQml0bWFwRG9jSWRTZXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...t/core/operator/filter/CombinedFilterOperator.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvQ29tYmluZWRGaWx0ZXJPcGVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...re/operator/query/FilteredAggregationOperator.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9GaWx0ZXJlZEFnZ3JlZ2F0aW9uT3BlcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/pinot/core/plan/AggregationPlanNode.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0FnZ3JlZ2F0aW9uUGxhbk5vZGUuamF2YQ==) | `0.00% <0.00%> (-92.99%)` | :arrow_down: |
   | ... and [1300 more](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3f11902...8df9f57](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] Jackie-Jiang commented on pull request #8097: fix FST Like query benchmark to remove SQL parsing from the measurement

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on pull request #8097:
URL: https://github.com/apache/pinot/pull/8097#issuecomment-1029366776


   @atris Have you got a chance to look at this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] richardstartin commented on pull request #8097: fix FST Like query benchmark to remove SQL parsing from the measurement

Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #8097:
URL: https://github.com/apache/pinot/pull/8097#issuecomment-1026096193


   At 100 blocks planning time still dominates this benchmark, but the cost of block iteration can be seen to increase for Lucene:
   
   Lucene:
   <img width="1530" alt="Screenshot 2022-01-31 at 18 43 11" src="https://user-images.githubusercontent.com/16439049/151853468-5a5535e1-70a5-47e0-82c5-323601fd16fc.png">
   
   Native:
   <img width="781" alt="Screenshot 2022-01-31 at 18 42 30" src="https://user-images.githubusercontent.com/16439049/151853351-1ce9b073-75ce-4622-83b6-2d830e915b1a.png">
    
   
   ```
   Benchmark                                (_fstType)  (_intBaseValue)  (_numBlocks)  (_numRows)                                                                 (_query)  Mode  Cnt    Score    Error  Units
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000             0     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5   58.150 ±  8.321  us/op
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000             1     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5   64.661 ±  6.074  us/op
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000            10     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5   70.470 ±  3.328  us/op
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000           100     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5  135.908 ±  6.255  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000             0     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5  223.925 ± 28.949  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000             1     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5  243.418 ± 78.130  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000            10     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5  232.884 ± 18.010  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000           100     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5  299.587 ± 30.918  us/op
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] Jackie-Jiang commented on pull request #8097: fix FST Like query benchmark to remove SQL parsing from the measurement

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on pull request #8097:
URL: https://github.com/apache/pinot/pull/8097#issuecomment-1026135964


   @atris Can you please take a look at this PR, and see if the benchmark result is valid? If so, we should revisit the native FST solution and make its performance at least on par with Lucene FST


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] richardstartin commented on pull request #8097: fix FST Like query benchmark to remove SQL parsing from the measurement

Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #8097:
URL: https://github.com/apache/pinot/pull/8097#issuecomment-1035516659


   I'm going to go ahead and merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] richardstartin merged pull request #8097: fix FST Like query benchmark to remove SQL parsing from the measurement

Posted by GitBox <gi...@apache.org>.
richardstartin merged pull request #8097:
URL: https://github.com/apache/pinot/pull/8097


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] richardstartin commented on pull request #8097: fix FST Like query benchmark to remove SQL parsing from the measurement

Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #8097:
URL: https://github.com/apache/pinot/pull/8097#issuecomment-1026076363


   I've added a parameter to vary the number of blocks iterated over so this benchmark doesn't just measure planning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] richardstartin commented on pull request #8097: fix FST Like query benchmark to remove SQL parsing from the measurement

Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #8097:
URL: https://github.com/apache/pinot/pull/8097#issuecomment-1026188530


   Added a query to match a prefix - Lucene winning for prefix queries too:
   
   ```
   Benchmark                                (_fstType)  (_intBaseValue)  (_numBlocks)  (_numRows)                                                                    (_query)  Mode  Cnt    Score    Error  Units
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000           100     2500000     SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5  140.027 ± 18.472  us/op
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000           100     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE 'www.domain%'  avgt    5  177.205 ± 15.342  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000           100     2500000     SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5  304.332 ± 92.048  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000           100     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE 'www.domain%'  avgt    5  290.019 ± 57.574  us/op
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8097: fix FST Like query benchmark to remove SQL parsing from the measurement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8097:
URL: https://github.com/apache/pinot/pull/8097#issuecomment-1026215800


   # [Codecov](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8097](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af0c74d) into [master](https://codecov.io/gh/apache/pinot/commit/3f11902d3f570ef6d3a9c0eeb6504f911e039256?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f11902) will **decrease** coverage by `6.39%`.
   > The diff coverage is `71.01%`.
   
   > :exclamation: Current head af0c74d differs from pull request most recent head 8df9f57. Consider uploading reports for the commit 8df9f57 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/pinot/pull/8097/graphs/tree.svg?width=650&height=150&src=pr&token=4ibza2ugkz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8097      +/-   ##
   ============================================
   - Coverage     71.21%   64.81%   -6.40%     
   - Complexity     4263     4306      +43     
   ============================================
     Files          1607     1572      -35     
     Lines         83409    81919    -1490     
     Branches      12458    12313     -145     
   ============================================
   - Hits          59397    53097    -6300     
   - Misses        19972    25061    +5089     
   + Partials       4040     3761     -279     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | integration1 | `?` | |
   | integration2 | `?` | |
   | unittests1 | `68.01% <73.14%> (+0.09%)` | :arrow_up: |
   | unittests2 | `14.21% <2.47%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...pache/pinot/spi/stream/StreamConfigProperties.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvc3RyZWFtL1N0cmVhbUNvbmZpZ1Byb3BlcnRpZXMuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ls/nativefst/mutablefst/utils/MutableFSTUtils.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC91dGlscy9uYXRpdmVmc3QvbXV0YWJsZWZzdC91dGlscy9NdXRhYmxlRlNUVXRpbHMuamF2YQ==) | `11.53% <11.53%> (ø)` | |
   | [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1NlZ21lbnREZWxldGlvbk1hbmFnZXIuamF2YQ==) | `70.45% <29.16%> (-6.79%)` | :arrow_down: |
   | [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvTExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `45.44% <40.00%> (-25.64%)` | :arrow_down: |
   | [...apache/pinot/core/operator/blocks/FilterBlock.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvRmlsdGVyQmxvY2suamF2YQ==) | `50.00% <50.00%> (-7.15%)` | :arrow_down: |
   | [...local/utils/nativefst/mutablefst/MutableState.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC91dGlscy9uYXRpdmVmc3QvbXV0YWJsZWZzdC9NdXRhYmxlU3RhdGUuamF2YQ==) | `50.00% <50.00%> (ø)` | |
   | [...java/org/apache/pinot/spi/stream/StreamConfig.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvc3RyZWFtL1N0cmVhbUNvbmZpZy5qYXZh) | `90.76% <50.00%> (-1.38%)` | :arrow_down: |
   | [...t/local/utils/nativefst/mutablefst/MutableArc.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC91dGlscy9uYXRpdmVmc3QvbXV0YWJsZWZzdC9NdXRhYmxlQXJjLmphdmE=) | `54.54% <54.54%> (ø)` | |
   | [.../pinot/core/operator/docidsets/BitmapDocIdSet.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvQml0bWFwRG9jSWRTZXQuamF2YQ==) | `62.50% <60.00%> (-37.50%)` | :arrow_down: |
   | [...cal/utils/nativefst/mutablefst/MutableFSTImpl.java](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC91dGlscy9uYXRpdmVmc3QvbXV0YWJsZWZzdC9NdXRhYmxlRlNUSW1wbC5qYXZh) | `66.66% <66.66%> (ø)` | |
   | ... and [393 more](https://codecov.io/gh/apache/pinot/pull/8097/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3f11902...8df9f57](https://codecov.io/gh/apache/pinot/pull/8097?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org