You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Heng Li (JIRA)" <ji...@apache.org> on 2017/12/20 16:45:01 UTC
[jira] [Commented] (HADOOP-13485) Log refactoring: method
invocation should be replaced by variable in hadoop tools
[ https://issues.apache.org/jira/browse/HADOOP-13485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298722#comment-16298722 ]
Heng Li commented on HADOOP-13485:
----------------------------------
Hi [~vrushalic], the patch has been here for a long time. I think we need to submit the patch to enable Jenkins pre-commit checks before a reviewer would review the code. Could you please submit the patch firstly? Thanks.
> Log refactoring: method invocation should be replaced by variable in hadoop tools
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-13485
> URL: https://issues.apache.org/jira/browse/HADOOP-13485
> Project: Hadoop Common
> Issue Type: Bug
> Components: tools
> Affects Versions: 2.7.2
> Reporter: Nemo Chen
> Labels: easy
> Attachments: HADOOP-13485.001.patch
>
>
> Similar to the fix for HDFS-409. In file:
> hadoop-rel-release-2.7.2/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
> {code:borderStyle=solid}
> this.blockSize = conf.getLong(AZURE_BLOCK_SIZE_PROPERTY_NAME,
> MAX_AZURE_BLOCK_SIZE);
> if (LOG.isDebugEnabled()) {
> LOG.debug("NativeAzureFileSystem. Initializing.");
> LOG.debug(" blockSize = "
> + conf.getLong(AZURE_BLOCK_SIZE_PROPERTY_NAME, MAX_AZURE_BLOCK_SIZE));
> }
> {code}
> For simplicity and readability, the {{conf.getLong(AZURE_BLOCK_SIZE_PROPERTY_NAME, MAX_AZURE_BLOCK_SIZE))}} should be changed to {{this.blockSize}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org