You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ZihanLi58 (via GitHub)" <gi...@apache.org> on 2023/09/01 01:46:24 UTC
[GitHub] [gobblin] ZihanLi58 commented on a diff in pull request #3751: [GOBBLIN-1891] Create selftuning buffered ORC writer
ZihanLi58 commented on code in PR #3751:
URL: https://github.com/apache/gobblin/pull/3751#discussion_r1312440720
##########
gobblin-modules/gobblin-orc/src/main/java/org/apache/gobblin/writer/OrcConverterMemoryManager.java:
##########
@@ -65,7 +71,20 @@ public long calculateSizeOfColHelper(ColumnVector col) {
for (int j = 0; j < unionColumnVector.fields.length; j++) {
converterBufferColSize += calculateSizeOfColHelper(unionColumnVector.fields[j]);
}
+ } else if (col instanceof LongColumnVector) {
+ // Memory space in bytes of native type
+ converterBufferColSize += col.isNull.length * 8;
Review Comment:
Can we merge these three branch together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org