You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/26 17:24:03 UTC

[GitHub] [flink] nielsbasjes opened a new pull request #11228: [FLINK-16293] Document using plugins in Kubernetes

nielsbasjes opened a new pull request #11228: [FLINK-16293] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228
 
 
   ## What is the purpose of the change
   
   * Document enabling plugins like S3 when running Flink natively on Kubernetes*
   
   ## Brief change log
   
   * Only documentation*
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? docs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann commented on a change in pull request #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228#discussion_r395085845
 
 

 ##########
 File path: docs/ops/deployment/docker.md
 ##########
 @@ -68,6 +68,37 @@ Therefore, one needs to build a dedicated container image for every job.
 The `flink-container` module contains a `build.sh` script which can be used to create such an image.
 Please see the [instructions](https://github.com/apache/flink/blob/{{ site.github_branch }}/flink-container/docker/README.md) for more details. 
 
+## Using plugins
+As described in the [plugins]({{ site.baseurl }}/ops/plugins.html) documentation page: in order to use plugins they must be
+copied to the correct location in the flink installation for them to work.
 
 Review comment:
   ```suggestion
   copied to the correct location in the Flink installation for them to work.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228#issuecomment-591551481
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150700597",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5648",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0821df9960f5fb77f01cc4e56821ce8add345b4e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150700597) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5648) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228#issuecomment-591551481
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150700597",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5648",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0821df9960f5fb77f01cc4e56821ce8add345b4e Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150700597) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5648) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228#issuecomment-591551481
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0821df9960f5fb77f01cc4e56821ce8add345b4e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann commented on a change in pull request #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228#discussion_r395088324
 
 

 ##########
 File path: docs/ops/deployment/kubernetes.md
 ##########
 @@ -91,15 +91,28 @@ In order to terminate the Flink session cluster, use `kubectl`:
 
 ## Flink job cluster on Kubernetes
 
-A Flink job cluster is a dedicated cluster which runs a single job. 
-The job is part of the image and, thus, there is no extra job submission needed. 
+A Flink job cluster is a dedicated cluster which runs a single job.
+The job is part of the image and, thus, there is no extra job submission needed.
 
 ### Creating the job-specific image
 
 The Flink job cluster image needs to contain the user code jars of the job for which the cluster is started.
 Therefore, one needs to build a dedicated container image for every job.
 Please follow these [instructions](https://github.com/apache/flink/blob/{{ site.github_branch }}/flink-container/docker/README.md) to build the Docker image.
-    
+
+### Using plugins
+
+As described in the [plugins]({{ site.baseurl }}/ops/plugins.html) documentation page: in order to use plugins they must be
+copied to the correct location in the flink installation for them to work.
+
+The simplest way to enable plugins for use on Kubernetes is to modify the provided Flink docker image by adding
+an additional layer. This does however assume you have a docker registry available where you can push images to and
+that is accessible by your Kubernetes cluster.
+
+How this can be done is described on the [Docker Setup]({{ site.baseurl }}/zh/ops/deployment/docker.html#using-plugins) page.
+
+With such an image created you can now start your Kubernetes based Flink cluster with image that was created.
 
 Review comment:
   ```suggestion
   With such an image created you can now start your Kubernetes based Flink cluster which can use the enabled plugins.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228#issuecomment-591551481
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150700597",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0821df9960f5fb77f01cc4e56821ce8add345b4e Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150700597) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann closed pull request #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228#issuecomment-591551481
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150700597",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5648",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151700015",
       "triggerID" : "c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5903",
       "triggerID" : "c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151700015) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5903) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228#issuecomment-591551481
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150700597",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5648",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151700015",
       "triggerID" : "c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5903",
       "triggerID" : "c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151700015) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5903) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228#issuecomment-591551481
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150700597",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5648",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151700015",
       "triggerID" : "c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0821df9960f5fb77f01cc4e56821ce8add345b4e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150700597) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5648) 
   * c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151700015) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann commented on a change in pull request #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228#discussion_r395088755
 
 

 ##########
 File path: docs/ops/deployment/kubernetes.zh.md
 ##########
 @@ -100,6 +100,19 @@ The Flink job cluster image needs to contain the user code jars of the job for w
 Therefore, one needs to build a dedicated container image for every job.
 Please follow these [instructions](https://github.com/apache/flink/blob/{{ site.github_branch }}/flink-container/docker/README.md) to build the Docker image.
 
+### Using plugins
+
+As described in the [plugins]({{ site.baseurl }}/zh/ops/plugins.html) documentation page: in order to use plugins they must be
+copied to the correct location in the flink installation for them to work.
+
+The simplest way to enable plugins for use on Kubernetes is to modify the provided Flink docker image by adding
+an additional layer. This does however assume you have a docker registry available where you can push images to and
+that is accessible by your Kubernetes cluster.
+
+How this can be done is described on the [Docker Setup]({{ site.baseurl }}/zh/ops/deployment/docker.html#using-plugins) page.
+
+With such an image created you can now start your Kubernetes based Flink cluster with image that was created.
 
 Review comment:
   ```suggestion
   With such an image created you can now start your Kubernetes based Flink cluster which can use the enabled plugins.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228#issuecomment-591545661
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 2447d931e2e84a25752eda846b6286552237402f (Wed Feb 26 17:27:39 UTC 2020)
   
   **Warnings:**
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16293).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228#issuecomment-591551481
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150700597",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5648",
       "triggerID" : "0821df9960f5fb77f01cc4e56821ce8add345b4e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0821df9960f5fb77f01cc4e56821ce8add345b4e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150700597) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5648) 
   * c38ed0aa0f026ffaea7d1a12ea5775f80ff2d9eb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann commented on a change in pull request #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11228: [FLINK-16293][Kubernetes] Document using plugins in Kubernetes
URL: https://github.com/apache/flink/pull/11228#discussion_r395086899
 
 

 ##########
 File path: docs/ops/deployment/docker.zh.md
 ##########
 @@ -68,6 +68,37 @@ Therefore, one needs to build a dedicated container image for every job.
 The `flink-container` module contains a `build.sh` script which can be used to create such an image.
 Please see the [instructions](https://github.com/apache/flink/blob/{{ site.github_branch }}/flink-container/docker/README.md) for more details. 
 
+## Using plugins
+As described in the [plugins]({{ site.baseurl }}/zh/ops/plugins.html) documentation page: in order to use plugins they must be
+copied to the correct location in the flink installation for them to work.
 
 Review comment:
   ```suggestion
   copied to the correct location in the Flink installation for them to work.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services