[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #2299: [INLONG-2161][Feature][Manager] Add sort_id_params table for getClusterConfig interface

[GitBox <gi...@apache.org>]

luchunliang commented on a change in pull request #2299:
URL: https://github.com/apache/incubator-inlong/pull/2299#discussion_r790612994



##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/SortIdParamsEntity.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Builder;
+import lombok.Data;
+
+import java.io.Serializable;
+
+@Data
+@Builder
+public class SortIdParamsEntity implements Serializable {
+    private Integer id;
+    private String taskName;
+    private String type;

Review comment:
       What is the type of id params?

##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sort/SortClusterConfigResponse.java
##########
@@ -33,14 +33,18 @@
     String md5;
     List<SortTaskConfig> tasks;
 
+    @Builder
+    @Data
     public static class SortClusterConfig {
         String clusterName;
         List<SortTaskConfig> sortTasks;
     }
 
+    @Builder
+    @Data
     public static class SortTaskConfig {
         String taskName;
-        String type;
+        String sinkType;

Review comment:
       sinkType can be enumeration

##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/SortIdParamsEntity.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Builder;
+import lombok.Data;
+
+import java.io.Serializable;
+
+@Data
+@Builder
+public class SortIdParamsEntity implements Serializable {
+    private Integer id;
+    private String taskName;
+    private String type;

Review comment:
       String/integer or the others.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org