You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by namannigam <gi...@git.apache.org> on 2017/08/10 03:22:45 UTC
[GitHub] commons-lang pull request #282: SwappedPair constructed as Pair.of(rhs,lhs)
GitHub user namannigam opened a pull request:
https://github.com/apache/commons-lang/pull/282
SwappedPair constructed as Pair.of(rhs,lhs)
There seems to be a bug in the current implementation of the `isRegistered` implementation, where the `swappedPair` is constructed similarly to the existing `pair` to check their existence in registry.
Source of finding - [StackOverflow#45603317](https://stackoverflow.com/questions/45603317/)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/namannigam/commons-lang master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/282.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #282
----
commit 9cf2568f2429ad84469a09f2480effc47c0467ec
Author: namannigam <na...@gmail.com>
Date: 2017-08-10T03:15:27Z
SwappedPair constructed as Pair.of(rhs,lhs)
commit 17bb505f2ab99f61b9fe99fb549df3dbdda957ff
Author: namannigam <na...@gmail.com>
Date: 2017-08-10T03:19:37Z
Revert import format
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-lang/pull/282
+1 on the unit test request, we need it to avoid regressions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/282
[](https://coveralls.io/builds/12772155)
Coverage increased (+0.03%) to 95.214% when pulling **17bb505f2ab99f61b9fe99fb549df3dbdda957ff on namannigam:master** into **05d9518038ae8d2ac9f11b91b731f47b909a9bad on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)
Posted by namannigam <gi...@git.apache.org>.
Github user namannigam commented on the issue:
https://github.com/apache/commons-lang/pull/282
@kinow @garydgregory Sure would try to come back soon with a unit test for the use-case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #282: SwappedPair constructed as Pair.of(rhs,lhs)
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/282
---
[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/282
I added a test. Thanks for the pull request! :+1:
---
[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/282
Makes sense, good catch. However, would be nice to have a unit test at least to cover that case, and make sure we don't have any regression for this behaviour. Would you be able to create one @namannigam ?
Thanks!!!
Bruno
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/282
created https://issues.apache.org/jira/browse/LANG-1349 to track this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---