You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "linrrzqqq (via GitHub)" <gi...@apache.org> on 2026/05/29 01:54:01 UTC
[PR] [Fix](FoldConst) Preserve NaN in numeric constant folding [doris]
linrrzqqq opened a new pull request, #63870:
URL: https://github.com/apache/doris/pull/63870
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](FoldConst) Preserve NaN in numeric constant folding [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #63870:
URL: https://github.com/apache/doris/pull/63870#issuecomment-4571338293
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](FoldConst) Preserve NaN in numeric constant folding [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63870:
URL: https://github.com/apache/doris/pull/63870#issuecomment-4573378426
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](FoldConst) Preserve NaN in numeric constant folding [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #63870:
URL: https://github.com/apache/doris/pull/63870#issuecomment-4571251454
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](FoldConst) Preserve NaN in numeric constant folding [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63870:
URL: https://github.com/apache/doris/pull/63870#issuecomment-4571639006
<details>
<summary>TPC-H: <b>Total hot run time: 31295 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ede20101e59463cfedf89a4bff22b34a624865f6, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17585 3948 3918 3918
q2 q3 10784 1424 799 799
q4 4684 477 344 344
q5 7555 2298 2060 2060
q6 241 175 134 134
q7 916 778 646 646
q8 9407 1912 1554 1554
q9 5177 5136 4920 4920
q10 6386 2217 1856 1856
q11 430 271 248 248
q12 632 428 292 292
q13 18131 3403 2759 2759
q14 263 253 232 232
q15 q16 810 774 712 712
q17 950 905 917 905
q18 6633 5684 5566 5566
q19 1288 1218 1060 1060
q20 537 404 373 373
q21 6416 2834 2604 2604
q22 442 375 313 313
Total cold run time: 99267 ms
Total hot run time: 31295 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4965 4761 4663 4663
q2 q3 4877 5298 4699 4699
q4 2060 2175 1370 1370
q5 5029 4740 4622 4622
q6 240 177 128 128
q7 1934 1740 1589 1589
q8 2426 2069 2096 2069
q9 7885 7387 7317 7317
q10 4755 4664 4242 4242
q11 525 380 356 356
q12 720 740 568 568
q13 2981 3356 2854 2854
q14 270 270 258 258
q15 q16 675 706 608 608
q17 1276 1245 1230 1230
q18 7334 6835 6578 6578
q19 1114 1079 1101 1079
q20 2215 2234 1942 1942
q21 5264 4555 4396 4396
q22 535 461 413 413
Total cold run time: 57080 ms
Total hot run time: 50981 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](FoldConst) Preserve NaN in numeric constant folding [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63870:
URL: https://github.com/apache/doris/pull/63870#issuecomment-4572021840
# FE UT Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63870_ede20101e59463cfedf89a4bff22b34a624865f6/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63870_ede20101e59463cfedf89a4bff22b34a624865f6/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](FoldConst) Preserve NaN in numeric constant folding [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63870:
URL: https://github.com/apache/doris/pull/63870#issuecomment-4571720339
<details>
<summary>TPC-DS: <b>Total hot run time: 171737 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ede20101e59463cfedf89a4bff22b34a624865f6, data reload: false
query5 4340 664 516 516
query6 337 219 194 194
query7 4225 567 307 307
query8 329 244 219 219
query9 8799 4004 4012 4004
query10 450 350 290 290
query11 5767 2587 2277 2277
query12 190 131 124 124
query13 1281 587 412 412
query14 6008 5422 5131 5131
query14_1 4399 4429 4386 4386
query15 207 207 186 186
query16 1009 435 413 413
query17 976 729 609 609
query18 2430 494 350 350
query19 224 203 159 159
query20 133 129 128 128
query21 225 139 116 116
query22 13818 13563 13369 13369
query23 17249 16488 16274 16274
query23_1 16349 16236 16357 16236
query24 7552 1785 1313 1313
query24_1 1323 1314 1310 1310
query25 543 478 418 418
query26 1338 308 172 172
query27 2707 563 340 340
query28 4498 2020 1984 1984
query29 1000 626 490 490
query30 306 239 204 204
query31 1133 1092 956 956
query32 92 74 73 73
query33 532 356 290 290
query34 1197 1126 673 673
query35 767 786 712 712
query36 1415 1444 1240 1240
query37 159 109 93 93
query38 3212 3192 3061 3061
query39 936 939 891 891
query39_1 903 894 868 868
query40 234 149 129 129
query41 72 70 68 68
query42 116 114 112 112
query43 328 330 290 290
query44
query45 217 212 201 201
query46 1121 1201 737 737
query47 2384 2444 2327 2327
query48 395 421 318 318
query49 653 504 406 406
query50 1018 371 251 251
query51 4385 4297 4315 4297
query52 110 107 95 95
query53 253 277 206 206
query54 326 288 272 272
query55 96 93 93 93
query56 318 321 324 321
query57 1487 1409 1341 1341
query58 312 291 284 284
query59 1628 1740 1456 1456
query60 327 337 318 318
query61 187 182 183 182
query62 704 656 595 595
query63 255 206 209 206
query64 2472 868 673 673
query65
query66 1735 497 370 370
query67 29732 29758 29620 29620
query68
query69 483 349 324 324
query70 1046 1037 1005 1005
query71 312 280 269 269
query72 3095 2772 2415 2415
query73 852 792 424 424
query74 5098 4936 4769 4769
query75 2682 2609 2282 2282
query76 2282 1157 806 806
query77 421 407 334 334
query78 12462 12578 11903 11903
query79 1449 992 764 764
query80 642 534 480 480
query81 451 285 242 242
query82 1393 159 122 122
query83 355 272 257 257
query84 307 141 113 113
query85 889 531 467 467
query86 425 340 308 308
query87 3420 3376 3249 3249
query88 3594 2755 2740 2740
query89 443 389 343 343
query90 1988 177 209 177
query91 182 171 144 144
query92 79 83 74 74
query93 1562 1452 839 839
query94 549 345 348 345
query95 680 383 458 383
query96 1028 770 350 350
query97 2727 2727 2648 2648
query98 232 229 224 224
query99 1148 1166 1036 1036
Total cold run time: 254457 ms
Total hot run time: 171737 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](FoldConst) Preserve NaN in numeric constant folding [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63870:
URL: https://github.com/apache/doris/pull/63870#issuecomment-4569809506
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](FoldConst) Preserve NaN in numeric constant folding [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63870:
URL: https://github.com/apache/doris/pull/63870#issuecomment-4573858356
# FE Regression Coverage Report
Increment line coverage ` 66.67% (2/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63870_ede20101e59463cfedf89a4bff22b34a624865f6_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63870_ede20101e59463cfedf89a4bff22b34a624865f6_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](FoldConst) Preserve NaN in numeric constant folding [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63870:
URL: https://github.com/apache/doris/pull/63870#issuecomment-4573377800
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](FoldConst) Preserve NaN in numeric constant folding [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb merged PR #63870:
URL: https://github.com/apache/doris/pull/63870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](FoldConst) Preserve NaN in numeric constant folding [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63870:
URL: https://github.com/apache/doris/pull/63870#issuecomment-4572731222
# FE Regression Coverage Report
Increment line coverage ` 66.67% (2/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63870_ede20101e59463cfedf89a4bff22b34a624865f6_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63870_ede20101e59463cfedf89a4bff22b34a624865f6_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](FoldConst) Preserve NaN in numeric constant folding [doris]
Posted by "linrrzqqq (via GitHub)" <gi...@apache.org>.
linrrzqqq commented on PR #63870:
URL: https://github.com/apache/doris/pull/63870#issuecomment-4573432636
> how about inf?
It could originally handle correctly
```text
Doris> select ln(cast('inf' as double));
+---------------------------+
| ln(cast('inf' as double)) |
+---------------------------+
| Infinity |
+---------------------------+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org