You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dnskr (via GitHub)" <gi...@apache.org> on 2023/01/25 18:22:30 UTC
[GitHub] [superset] dnskr opened a new pull request, #22854: feat(helm): Make Chart.AppVersion default value for image tag
dnskr opened a new pull request, #22854:
URL: https://github.com/apache/superset/pull/22854
### SUMMARY
The PR adds `appVersion` to `Chart.yaml`, pins default Superset version to `2.0.1` and uses it as a default value for image tag. The same logic is used in many other official helm charts.
This change also eliminates confusing `helm search repo` output saying chart deploys Superset 1.0:
```
$ helm search repo
NAME CHART VERSION APP VERSION DESCRIPTION
argo/argo-cd 5.19.6 v2.5.7 A Helm chart for Argo CD, a declarative, GitOps...
...
minio/operator 4.5.8 v4.5.8 A Helm chart for MinIO Operator
...
superset/superset 0.8.4 1.0 Apache Superset is a modern, enterprise-ready b...
```
### TESTING INSTRUCTIONS
Check that the right value is used by default `helm template test ./helm/superset`
```
apiVersion: apps/v1
kind: Deployment
metadata:
name: test-superset
...
spec:
containers:
- name: superset
image: "apache/superset:2.0.1"
```
and with custom image tag `helm template test ./helm/superset --set image.tag=custom`
```
apiVersion: apps/v1
kind: Deployment
metadata:
name: test-superset
...
spec:
containers:
- name: superset
image: "apache/superset:custom"
```
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sergeyshevch commented on pull request #22854: feat(helm): Make Chart.AppVersion default value for image tag
Posted by "sergeyshevch (via GitHub)" <gi...@apache.org>.
sergeyshevch commented on PR #22854:
URL: https://github.com/apache/superset/pull/22854#issuecomment-1407443003
@dnskr It can be my bad. I didn't execute pre-commit and I ran helm-docs directly instead. I can look more into it on Monday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dnskr commented on pull request #22854: feat(helm): Make Chart.AppVersion default value for image tag
Posted by "dnskr (via GitHub)" <gi...@apache.org>.
dnskr commented on PR #22854:
URL: https://github.com/apache/superset/pull/22854#issuecomment-1404300292
@craig-rueda Not sure why `helm-docs` hook failed. Should I revert `helm/superset/README.md` changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dnskr commented on pull request #22854: feat(helm): Make Chart.AppVersion default value for image tag
Posted by "dnskr (via GitHub)" <gi...@apache.org>.
dnskr commented on PR #22854:
URL: https://github.com/apache/superset/pull/22854#issuecomment-1404350204
> Please re-gen `/charts/superset/README.md` using `helm-docs`
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dnskr commented on pull request #22854: feat(helm): Make Chart.AppVersion default value for image tag
Posted by "dnskr (via GitHub)" <gi...@apache.org>.
dnskr commented on PR #22854:
URL: https://github.com/apache/superset/pull/22854#issuecomment-1405433452
> Looks like `helm-docs` hook is failing still
Are there any ideas why?
I've changed line separators from `CRLF` to `LF` and force pushed changes. Hope it will help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #22854: feat(helm): Make Chart.AppVersion default value for image tag
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #22854:
URL: https://github.com/apache/superset/pull/22854#issuecomment-1404387475
Looks like `helm-docs` hook is failing still
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #22854: feat(helm): Make Chart.AppVersion default value for image tag
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #22854:
URL: https://github.com/apache/superset/pull/22854#issuecomment-1405644105
You can always try running `pre-commit` locally to verify if this doesn't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dnskr commented on pull request #22854: feat(helm): Make Chart.AppVersion default value for image tag
Posted by "dnskr (via GitHub)" <gi...@apache.org>.
dnskr commented on PR #22854:
URL: https://github.com/apache/superset/pull/22854#issuecomment-1407363694
I have the same `pre-commit` output locally, so it doesn't help to solve the issue.
@sergeyshevch Could you please have a look what might be the issue since your commit is the last and successfully passed tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dnskr commented on pull request #22854: feat(helm): Make Chart.AppVersion default value for image tag
Posted by "dnskr (via GitHub)" <gi...@apache.org>.
dnskr commented on PR #22854:
URL: https://github.com/apache/superset/pull/22854#issuecomment-1410177865
@dpgaspar Done! Please approve to run tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #22854: feat(helm): Make Chart.AppVersion default value for image tag
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #22854:
URL: https://github.com/apache/superset/pull/22854#issuecomment-1404334580
Please re-gen `/charts/superset/README.md` using `helm-docs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sergeyshevch commented on pull request #22854: feat(helm): Make Chart.AppVersion default value for image tag
Posted by "sergeyshevch (via GitHub)" <gi...@apache.org>.
sergeyshevch commented on PR #22854:
URL: https://github.com/apache/superset/pull/22854#issuecomment-1410147255
I guess it's more for @dnskr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dnskr commented on pull request #22854: feat(helm): Make Chart.AppVersion default value for image tag
Posted by "dnskr (via GitHub)" <gi...@apache.org>.
dnskr commented on PR #22854:
URL: https://github.com/apache/superset/pull/22854#issuecomment-1404350263
> Please re-gen `/charts/superset/README.md` using `helm-docs`
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on pull request #22854: feat(helm): Make Chart.AppVersion default value for image tag
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on PR #22854:
URL: https://github.com/apache/superset/pull/22854#issuecomment-1410104407
@sergeyshevch this was a problem we had on CI, was fixed here: https://github.com/apache/superset/pull/22907
so please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #22854: feat(helm): Make Chart.AppVersion default value for image tag
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar merged PR #22854:
URL: https://github.com/apache/superset/pull/22854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org