You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/02 01:32:26 UTC

[GitHub] [spark] HyukjinKwon edited a comment on issue #24259: [SPARK-27328][SQL] Add 'deprecated' in ExpressionDescription for extended usage and SQL doc

HyukjinKwon edited a comment on issue #24259: [SPARK-27328][SQL] Add 'deprecated' in ExpressionDescription for extended usage and SQL doc
URL: https://github.com/apache/spark/pull/24259#issuecomment-478808428
 
 
   It is a few pieces of codes, yes. I was worrying about we start to have many flags under `SQLConf` (where we already have a lot). From what I have seen, it always grows but never decreases.
   
   Adding a configuration for each deprecation looked like it makes harder to deprecate and get out of the legacy stuff. (for instance, the SparkR and PySpark tests had to be fixed few times in #24195).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org