You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "bowenliang123 (via GitHub)" <gi...@apache.org> on 2023/08/14 01:06:14 UTC
[GitHub] [incubator-uniffle] bowenliang123 opened a new pull request, #1144: [#1143] docs: Correct sequence number text by reducing paragraph indentation by 1 space
bowenliang123 opened a new pull request, #1144:
URL: https://github.com/apache/incubator-uniffle/pull/1144
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
### Why are the changes needed?
Fix: #1143
Before:
After:
### Does this PR introduce _any_ user-facing change?
(Please list the user-facing changes introduced by your change, including
1. Change in user-facing APIs.
2. Addition or removal of property keys.)
No.
### How was this patch tested?
(Please test your changes, and provide instructions on how to test it:
1. If you add a feature or fix a bug, add a test to cover your changes.
2. If you fix a flaky test, repeat it for many times to prove it works.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #1144: [#1143] docs: Correct sequence number text by reducing paragraph indentation by 1 space
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1144:
URL: https://github.com/apache/incubator-uniffle/pull/1144#issuecomment-1676533946
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1144?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1144](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1144?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (43d9a7a) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/5af0e033e46c91ba53c553c1fc0803a1e40621ab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5af0e03) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1144 +/- ##
============================================
+ Coverage 53.71% 54.27% +0.55%
+ Complexity 2573 2104 -469
============================================
Files 391 319 -72
Lines 22314 14396 -7918
Branches 1867 1305 -562
============================================
- Hits 11986 7813 -4173
+ Misses 9621 6164 -3457
+ Partials 707 419 -288
```
[see 75 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1144/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] bowenliang123 commented on pull request #1144: [#1143] docs: Correct sequence number text by reducing paragraph indentation by 1 space
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #1144:
URL: https://github.com/apache/incubator-uniffle/pull/1144#issuecomment-1676562476
Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #1144: [#1143] docs: Correct sequence number text by reducing paragraph indentation by 1 space
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #1144:
URL: https://github.com/apache/incubator-uniffle/pull/1144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org