You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "sjhajharia (via GitHub)" <gi...@apache.org> on 2025/02/22 16:23:54 UTC
[PR] [MINOR] Clean up group-coordinator [kafka]
sjhajharia opened a new pull request, #19008:
URL: https://github.com/apache/kafka/pull/19008
Given that now we support Java 17 on our brokers, this PR replace the use of :
- `Collections.singletonList()` and `Collections.emptyList()` with `List.of()`
- `Collections.singletonMap()` and `Collections.emptyMap()` with `Map.of()`
- `Collections.singleton()` and `Collections.emptySet()` with `Set.of()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Clean up group-coordinator [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19008:
URL: https://github.com/apache/kafka/pull/19008#discussion_r1976408532
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/ConfiguredInternalTopic.java:
##########
@@ -62,7 +61,7 @@ public StreamsGroupDescribeResponseData.TopicInfo asStreamsGroupDescribeTopicInf
y -> new StreamsGroupDescribeResponseData.KeyValue()
.setKey(y.getKey())
.setValue(y.getValue())
- ).collect(Collectors.toList()) : null
Review Comment:
`topicConfigs` is never null, so could you please remove the null check. Also, according the schema, `StreamsGroupDescribeResponseData` can't accept null `topicConfigs`.
cc @lucasbru
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Clean up group-coordinator [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #19008:
URL: https://github.com/apache/kafka/pull/19008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Clean up group-coordinator [kafka]
Posted by "sjhajharia (via GitHub)" <gi...@apache.org>.
sjhajharia commented on PR #19008:
URL: https://github.com/apache/kafka/pull/19008#issuecomment-2687360738
hey @chia7712
Can you please take a look at this PR too. TIA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Clean up group-coordinator [kafka]
Posted by "sjhajharia (via GitHub)" <gi...@apache.org>.
sjhajharia commented on code in PR #19008:
URL: https://github.com/apache/kafka/pull/19008#discussion_r1976438007
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/ConfiguredInternalTopic.java:
##########
@@ -62,7 +61,7 @@ public StreamsGroupDescribeResponseData.TopicInfo asStreamsGroupDescribeTopicInf
y -> new StreamsGroupDescribeResponseData.KeyValue()
.setKey(y.getKey())
.setValue(y.getValue())
- ).collect(Collectors.toList()) : null
Review Comment:
Thanks @chia7712
I have addressed the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org