You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/22 07:23:27 UTC
[GitHub] [flink] lsyldliu opened a new pull request, #19553: [FLINK-27243][table] Support SHOW PARTITIONS statement for partitioned table
lsyldliu opened a new pull request, #19553:
URL: https://github.com/apache/flink/pull/19553
## What is the purpose of the change
Support SHOW PARTITIONS statement for partitioned table
## Brief change log
- *Support SHOW PARTITIONS statement for partitioned table*
## Verifying this change
This change added tests and can be verified as follows:
- *Added unit tests in SqlToOperationConverterTest*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no )
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
- The S3 file system connector: ( no )
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? ( docs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #19553: [FLINK-27243][table] Support SHOW PARTITIONS statement for partitioned table
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19553:
URL: https://github.com/apache/flink/pull/19553#discussion_r857360314
##########
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl:
##########
@@ -1614,6 +1614,25 @@ SqlDrop SqlDropExtended(Span s, boolean replace) :
}
}
+/** SHOW PARTITIONS table_name [PARTITION partition_spec]; */
Review Comment:
Nit:
```suggestion
/** SHOW PARTITIONS table_identidier [PARTITION partition_spec]; */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #19553: [FLINK-27243][table] Support SHOW PARTITIONS statement for partitioned table
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19553:
URL: https://github.com/apache/flink/pull/19553#discussion_r857362481
##########
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java:
##########
@@ -286,6 +286,12 @@ void testShowColumns() {
.ok("SHOW COLUMNS IN `CATALOG1`.`DB1`.`TBL` NOT LIKE '%'");
}
+ @Test
+ public void testShowPartitions() {
+ sql("show partitions tbl").ok("SHOW PARTITIONS `TBL`");
Review Comment:
add a test like
`show partitions c1.d1.tbl`
The [SqlToOperationConverterTest.java](https://github.com/apache/flink/pull/19553/files#diff-399da8a41d837c40407dfafce96c2cd186386e5f7931422b2f87b9dafdeb9dfd)#testShowPartitions is same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19553: [FLINK-27243][table] Support SHOW PARTITIONS statement for partitioned table
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19553:
URL: https://github.com/apache/flink/pull/19553#issuecomment-1106103994
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdbe0ba06575e3b32e6b87ebe456f6cf0a57cccc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdbe0ba06575e3b32e6b87ebe456f6cf0a57cccc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdbe0ba06575e3b32e6b87ebe456f6cf0a57cccc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org