[GitHub] [spark] heyihong commented on a diff in pull request #42363: [SPARK-44691][SQL][CONNECT] Move Subclasses of AnalysisException to sql/api

["heyihong (via GitHub)" <gi...@apache.org>]

heyihong commented on code in PR #42363:
URL: https://github.com/apache/spark/pull/42363#discussion_r1286134566


##########
sql/api/src/main/java/org/apache/spark/sql/connector/catalog/IdentifierImpl.java:
##########
@@ -17,14 +17,14 @@
 
 package org.apache.spark.sql.connector.catalog;
 
+import org.apache.arrow.util.Preconditions;

Review Comment:
   Yes
   ```
     IdentifierImpl(String[] namespace, String name) {
       Preconditions.checkNotNull(namespace, "Identifier namespace cannot be null");
       Preconditions.checkNotNull(name, "Identifier name cannot be null");
       this.namespace = namespace;
       this.name = name;
     }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org