You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2023/12/20 17:57:34 UTC
[I] The process is not terminated while invalid options are being loaded from configuration file [incubator-pegasus]
empiredan opened a new issue, #1807:
URL: https://github.com/apache/incubator-pegasus/issues/1807
While some options are loaded from configuration file with invalid values, all of them should be found by flags' individual and grouped validators and the process should be terminated by `abort()`.
However, after the options were set with invalid values in configuration file for test, the process was not terminated, and there were also not any error log.
By checking the code, it is found that flags' validation, for both individuals and groups, are actually run normally and correctly. The problem is that the loading for options happens before the logging is initialized. At that time, `simple_logger` has not been created. Default logger, i.e. `screen_logger`, would be used. Therefore, once invalid values are found, `screen_logger::dsn_log` would be called. However, this function is empty, thus there would not be any logging message being printed; and the process would never be terminated due to fatal error.
According to this analysis, once any assertion, such as `CHECK` or `CHECK_EQ`, would fail to be executed for the invalid values: never print any logging message and terminate the process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [I] The process is not terminated while invalid options are being loaded from configuration file [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan closed issue #1807: The process is not terminated while invalid options are being loaded from configuration file
URL: https://github.com/apache/incubator-pegasus/issues/1807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [I] The process is not terminated while invalid options are being loaded from configuration file [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on issue #1807:
URL: https://github.com/apache/incubator-pegasus/issues/1807#issuecomment-1867204282
This bug is fixed by https://github.com/apache/incubator-pegasus/pull/1803.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org