You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nitin-maharana <gi...@git.apache.org> on 2015/09/08 11:58:42 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8821: UI Change
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/786
CLOUDSTACK-8821: UI Change
It provides appropriate message in the UI when configuring the firewall rules in Network page.
If the default egress policy is allow, then it says to block traffic. If the default egress policy is deny, then it says to allow traffic.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nitin-maharana/cloudstack CloudStack-Nitin2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/786.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #786
----
commit 9dee193fdfd1e247ae5197c33df3f0715f77eb71
Author: Nitin Kumar Maharana <ni...@citrix.com>
Date: 2015-09-08T10:05:25Z
CLOUDSTACK-8821: Provide appropriate message in the UI when configuring the Firewall rules.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #786: CLOUDSTACK-8821: UI Change
Posted by GabrielAnca <gi...@git.apache.org>.
Github user GabrielAnca commented on the issue:
https://github.com/apache/cloudstack/pull/786
Dear Nitin,
I really appreciate your contribution to help end users understand what they are doing in this page - I honestly think that some sections need better explanations -, but having to close the pop up every time we access that page is a little annoying. Wouldn't it be better to show the informative text somewhere in the UI instead of showing a pop up every single time?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8821: UI Change
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/786#discussion_r39011419
--- Diff: ui/scripts/network.js ---
@@ -1612,6 +1613,36 @@
});
}
});
+
+ if (!isConfigRulesMsgShown) {
+ isConfigRulesMsgShown = true;
+ $.ajax({
+ url: createURL('listNetworkOfferings'),
+ data: {
+ id: args.context.networks[0].networkofferingid
+ },
+ dataType: 'json',
+ async: true,
+ success: function(json) {
+ var response = json.listnetworkofferingsresponse.networkoffering ?
+ json.listnetworkofferingsresponse.networkoffering[0] : null;
+
+ if (response != null) {
+ var egressdefaultpolicy;
+
+ if (response.egressdefaultpolicy == true) {
+ egressdefaultpolicy = 'Block';
+ } else {
+ egressdefaultpolicy = 'Allow';
+ }
+
+ cloudStack.dialog.notice({
+ message: _l('Configure the rules to ' + egressdefaultpolicy + ' Traffic.')
--- End diff --
I am making one more pull request with the change from a different branch. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #786: CLOUDSTACK-8821: UI Change
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/786
Hi @GabrielAnca,
Generally we show some information in notification field(Top-Right side corner), which disappears after one or two seconds. But that is used in case of any event occurs. I don't think other than that any field exists UI which will disappear without user interaction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8821: UI Change
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/786
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8821: UI Change
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/786#discussion_r38911089
--- Diff: ui/scripts/network.js ---
@@ -1612,6 +1613,36 @@
});
}
});
+
+ if (!isConfigRulesMsgShown) {
+ isConfigRulesMsgShown = true;
+ $.ajax({
+ url: createURL('listNetworkOfferings'),
+ data: {
+ id: args.context.networks[0].networkofferingid
+ },
+ dataType: 'json',
+ async: true,
+ success: function(json) {
+ var response = json.listnetworkofferingsresponse.networkoffering ?
+ json.listnetworkofferingsresponse.networkoffering[0] : null;
+
+ if (response != null) {
+ var egressdefaultpolicy;
+
+ if (response.egressdefaultpolicy == true) {
+ egressdefaultpolicy = 'Block';
+ } else {
+ egressdefaultpolicy = 'Allow';
+ }
+
+ cloudStack.dialog.notice({
+ message: _l('Configure the rules to ' + egressdefaultpolicy + ' Traffic.')
--- End diff --
Would be great if you can use a localization key from messages.properties (by adding the sentence inside) instead of hard code message to allow the localization of the web UI. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---