You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@turbine.apache.org by tv...@apache.org on 2009/05/18 20:07:43 UTC
svn commit: r776027 -
/turbine/fulcrum/trunk/testcontainer/src/test/org/apache/fulcrum/testcontainer/YaafiContainerTest.java
Author: tv
Date: Mon May 18 18:07:43 2009
New Revision: 776027
URL: http://svn.apache.org/viewvc?rev=776027&view=rev
Log:
I don't think this test could work at all. There is no such thing as an integrated roles file. I suspect the config file setting was just a leftover from some cut'n'paste operation. So I removed the test altogether.
Modified:
turbine/fulcrum/trunk/testcontainer/src/test/org/apache/fulcrum/testcontainer/YaafiContainerTest.java
Modified: turbine/fulcrum/trunk/testcontainer/src/test/org/apache/fulcrum/testcontainer/YaafiContainerTest.java
URL: http://svn.apache.org/viewvc/turbine/fulcrum/trunk/testcontainer/src/test/org/apache/fulcrum/testcontainer/YaafiContainerTest.java?rev=776027&r1=776026&r2=776027&view=diff
==============================================================================
--- turbine/fulcrum/trunk/testcontainer/src/test/org/apache/fulcrum/testcontainer/YaafiContainerTest.java (original)
+++ turbine/fulcrum/trunk/testcontainer/src/test/org/apache/fulcrum/testcontainer/YaafiContainerTest.java Mon May 18 18:07:43 2009
@@ -88,7 +88,7 @@
try
{
sc = (SimpleComponent) this.lookup(SimpleComponent.class.getName());
- fail("We should fail");
+ fail("We should fail");
}
catch (ComponentException e)
{
@@ -100,27 +100,4 @@
// We expect to fail with a ConfigurationException
}
}
-
- public void testLoadingContainerWithIntegratedRolesfile()
- {
- SimpleComponent sc = null;
-
- this.setRoleFileName(null);
- this.setConfigurationFileName(
- "src/test/TestComponentConfigIntegratedRoles.xml");
- try
- {
- sc = (SimpleComponent) this.lookup(SimpleComponent.ROLE);
- }
- catch (Exception e)
- {
- e.printStackTrace();
- fail(e.getMessage());
- }
- assertTrue(sc instanceof AlternativeComponentImpl);
- assertNotNull(sc);
- sc.test();
- this.release(sc);
- }
-
}
Re: svn commit: r776027 - /turbine/fulcrum/trunk/testcontainer/src/test/org/apache/fulcrum/testcontainer/YaafiContainerTest.java
Posted by Thomas Vandahl <tv...@apache.org>.
Scott Eade wrote:
> Does the "Configuring the Components" section of
> http://turbine.apache.org/builds/fulcrum/fulcrum-testcontainer/1.0.6/RC2/site/
> need to be updated to remove the integrated example?
AFAICT, this integrated file format is specific to the ECMContainer, so
the test was indeed a leftover from cut'n'paste. So updating probably
means that this particular configuration method is only available with
the ECMContainer.
Bye, Thomas.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org
Re: svn commit: r776027 - /turbine/fulcrum/trunk/testcontainer/src/test/org/apache/fulcrum/testcontainer/YaafiContainerTest.java
Posted by Scott Eade <se...@backstagetech.com.au>.
Does the "Configuring the Components" section of
http://turbine.apache.org/builds/fulcrum/fulcrum-testcontainer/1.0.6/RC2/site/
need to be updated to remove the integrated example?
Scott
tv@apache.org wrote:
> Author: tv
> Date: Mon May 18 18:07:43 2009
> New Revision: 776027
>
> URL: http://svn.apache.org/viewvc?rev=776027&view=rev
> Log:
> I don't think this test could work at all. There is no such thing as an integrated roles file. I suspect the config file setting was just a leftover from some cut'n'paste operation. So I removed the test altogether.
>
> Modified:
> turbine/fulcrum/trunk/testcontainer/src/test/org/apache/fulcrum/testcontainer/YaafiContainerTest.java
>
> Modified: turbine/fulcrum/trunk/testcontainer/src/test/org/apache/fulcrum/testcontainer/YaafiContainerTest.java
> URL: http://svn.apache.org/viewvc/turbine/fulcrum/trunk/testcontainer/src/test/org/apache/fulcrum/testcontainer/YaafiContainerTest.java?rev=776027&r1=776026&r2=776027&view=diff
> ==============================================================================
> --- turbine/fulcrum/trunk/testcontainer/src/test/org/apache/fulcrum/testcontainer/YaafiContainerTest.java (original)
> +++ turbine/fulcrum/trunk/testcontainer/src/test/org/apache/fulcrum/testcontainer/YaafiContainerTest.java Mon May 18 18:07:43 2009
> @@ -88,7 +88,7 @@
> try
> {
> sc = (SimpleComponent) this.lookup(SimpleComponent.class.getName());
> - fail("We should fail");
> + fail("We should fail");
> }
> catch (ComponentException e)
> {
> @@ -100,27 +100,4 @@
> // We expect to fail with a ConfigurationException
> }
> }
> -
> - public void testLoadingContainerWithIntegratedRolesfile()
> - {
> - SimpleComponent sc = null;
> -
> - this.setRoleFileName(null);
> - this.setConfigurationFileName(
> - "src/test/TestComponentConfigIntegratedRoles.xml");
> - try
> - {
> - sc = (SimpleComponent) this.lookup(SimpleComponent.ROLE);
> - }
> - catch (Exception e)
> - {
> - e.printStackTrace();
> - fail(e.getMessage());
> - }
> - assertTrue(sc instanceof AlternativeComponentImpl);
> - assertNotNull(sc);
> - sc.test();
> - this.release(sc);
> - }
> -
> }
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org