You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/11 06:13:58 UTC
[GitHub] [incubator-mxnet] litaotju opened a new pull request #17271: Fix
#17267, add expected and got datatype for concat error msgs
litaotju opened a new pull request #17271: Fix #17267, add expected and got datatype for concat error msgs
URL: https://github.com/apache/incubator-mxnet/pull/17271
## Description ##
Fix #17267, add expected and got datatype for concat error msgs
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull
request #17271: Fix #17267,
add expected and got datatype for concat error msgs
Posted by GitBox <gi...@apache.org>.
eric-haibin-lin commented on a change in pull request #17271: Fix #17267, add expected and got datatype for concat error msgs
URL: https://github.com/apache/incubator-mxnet/pull/17271#discussion_r365558618
##########
File path: src/operator/nn/concat.cc
##########
@@ -149,9 +149,10 @@ bool ConcatType(const nnvm::NodeAttrs& attrs,
if (dtype == -1) {
dtype = i;
} else {
- CHECK(i == dtype ||
- i == -1) <<
- "Non-uniform data type in Concat";
+ CHECK( i == dtype || i == -1)
Review comment:
Split the msg sounds more clear. Maybe we can template the function with the op name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #17271: Fix
#17267, add expected and got datatype for concat error msgs
Posted by GitBox <gi...@apache.org>.
eric-haibin-lin commented on issue #17271: Fix #17267, add expected and got datatype for concat error msgs
URL: https://github.com/apache/incubator-mxnet/pull/17271#issuecomment-574297555
Great. Thansk for the fix! @litaotju
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull
request #17271: Fix #17267,
add expected and got datatype for concat error msgs
Posted by GitBox <gi...@apache.org>.
eric-haibin-lin commented on a change in pull request #17271: Fix #17267, add expected and got datatype for concat error msgs
URL: https://github.com/apache/incubator-mxnet/pull/17271#discussion_r365505412
##########
File path: src/operator/nn/concat.cc
##########
@@ -149,9 +149,10 @@ bool ConcatType(const nnvm::NodeAttrs& attrs,
if (dtype == -1) {
dtype = i;
} else {
- CHECK(i == dtype ||
- i == -1) <<
- "Non-uniform data type in Concat";
+ CHECK( i == dtype || i == -1)
Review comment:
Thanks for the fix! Two suggestions:
- this function is used for both Concat and dstack. Can we extend the error msg to `Non-uniform data type in Concat / dstack.... ` ?
- can we extend the last sentenve and show the index of the data type : `..... got data type x at position y`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] litaotju commented on a change in pull request
#17271: Fix #17267, add expected and got datatype for concat error msgs
Posted by GitBox <gi...@apache.org>.
litaotju commented on a change in pull request #17271: Fix #17267, add expected and got datatype for concat error msgs
URL: https://github.com/apache/incubator-mxnet/pull/17271#discussion_r365578922
##########
File path: src/operator/nn/concat.cc
##########
@@ -149,9 +149,10 @@ bool ConcatType(const nnvm::NodeAttrs& attrs,
if (dtype == -1) {
dtype = i;
} else {
- CHECK(i == dtype ||
- i == -1) <<
- "Non-uniform data type in Concat";
+ CHECK( i == dtype || i == -1)
Review comment:
Add the op info in msg. Marking as resolved. Feel free to re-open.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] litaotju commented on issue #17271: Fix #17267,
add expected and got datatype for concat error msgs
Posted by GitBox <gi...@apache.org>.
litaotju commented on issue #17271: Fix #17267, add expected and got datatype for concat error msgs
URL: https://github.com/apache/incubator-mxnet/pull/17271#issuecomment-573631949
> @litaotju Please fix the lint problem: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fsanity/detail/PR-17271/2/pipeline.
Thanks @haojin2, fixed by https://github.com/apache/incubator-mxnet/pull/17271/commits/c835c36af6f43c245674362c6ccb2f51ab52e67d
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] litaotju commented on a change in pull request
#17271: Fix #17267, add expected and got datatype for concat error msgs
Posted by GitBox <gi...@apache.org>.
litaotju commented on a change in pull request #17271: Fix #17267, add expected and got datatype for concat error msgs
URL: https://github.com/apache/incubator-mxnet/pull/17271#discussion_r365509263
##########
File path: src/operator/nn/concat.cc
##########
@@ -149,9 +149,10 @@ bool ConcatType(const nnvm::NodeAttrs& attrs,
if (dtype == -1) {
dtype = i;
} else {
- CHECK(i == dtype ||
- i == -1) <<
- "Non-uniform data type in Concat";
+ CHECK( i == dtype || i == -1)
Review comment:
Do you want to split the msg explicitly of "Concat" and "dstack" based on the op name. Or just use the sentence "Non-uniform data type in Concat / dstack....", and no need to state if it's Concat or dstack ?
Yes, the second one can be done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] haojin2 commented on issue #17271: Fix #17267,
add expected and got datatype for concat error msgs
Posted by GitBox <gi...@apache.org>.
haojin2 commented on issue #17271: Fix #17267, add expected and got datatype for concat error msgs
URL: https://github.com/apache/incubator-mxnet/pull/17271#issuecomment-573506905
@litaotju Please fix the lint problem: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fsanity/detail/PR-17271/2/pipeline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] eric-haibin-lin merged pull request #17271: Fix
#17267, add expected and got datatype for concat error msgs
Posted by GitBox <gi...@apache.org>.
eric-haibin-lin merged pull request #17271: Fix #17267, add expected and got datatype for concat error msgs
URL: https://github.com/apache/incubator-mxnet/pull/17271
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services