You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Haisheng Yuan (Jira)" <ji...@apache.org> on 2019/10/04 03:59:00 UTC
[jira] [Commented] (CALCITE-3334) Refinement for Substitution-Based
MV Matching
[ https://issues.apache.org/jira/browse/CALCITE-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944197#comment-16944197 ]
Haisheng Yuan commented on CALCITE-3334:
----------------------------------------
[~jinxing6042@126.com] I still don't quite get why you provide an option to disable SubstitutionVisitor. If both code paths can work, why do we need to keep both?
> Refinement for Substitution-Based MV Matching
> ---------------------------------------------
>
> Key: CALCITE-3334
> URL: https://issues.apache.org/jira/browse/CALCITE-3334
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: jin xing
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The approach of substitution-based MV matching is an effective way for its simplicity and extensibility.
> This JIRA proposes to refine existing implementation by several points:
> # Canonicalize before MV matching -- by such canonicalization we can significantly simplify the algebra tree and lower the difficulty for materialization matching.
> # Separate matching rules into two categories and enumerate common matching patterns which need to be covered by rules.
> Please check the design doc: [Design Doc|https://docs.google.com/document/d/1JpwGNFE3hw3yXb7W3-95-jXKClZC5UFPKbuhgYDuEu4/edit#]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)