[jira] [Work logged] (CURATOR-541) Infinite loop/repeat in BaseClassForTests

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CURATOR-541?focusedWorklogId=316163&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316163 ]

ASF GitHub Bot logged work on CURATOR-541:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/19 17:59
            Start Date: 21/Sep/19 17:59
    Worklog Time Spent: 10m 
      Work Description: Randgalt commented on pull request #326: [CURATOR-541] Fix retry code in BaseClassForTests
URL: https://github.com/apache/curator/pull/326
 
 
   The retry code in BaseClassForTests was hopelessly broken - I don't know for how long. Reworked it so that it does the right thing now (hopefully). Storing the retry count as an attribute wasn't working. The new method stores it as a field in the test class and makes sure that it's always correct. It should only ever be true when actually retrying and, given that TestNG always calls the retry method, it can be reset after a retry fails.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 316163)
    Remaining Estimate: 0h
            Time Spent: 10m

> Infinite loop/repeat in BaseClassForTests
> -----------------------------------------
>
>                 Key: CURATOR-541
>                 URL: https://issues.apache.org/jira/browse/CURATOR-541
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 4.2.0
>            Reporter: Jordan Zimmerman
>            Priority: Critical
>             Fix For: 4.3.0
>
>         Attachments: Screen Shot 2019-09-21 at 11.21.03 AM.png
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> A Curator test that consistently fails will cause an infinite loop of retries when test class extends {{BaseClassForTests}} E.g.
> {code}
>     @Test
>     public void infiniteLoop() {
>         Assert.fail();
>     }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)