[GitHub] [beam] damccorm commented on a change in pull request #17047: [BEAM-3304] documentation for PaneInfo in BPG

[GitBox <gi...@apache.org>]

damccorm commented on a change in pull request #17047:
URL: https://github.com/apache/beam/pull/17047#discussion_r822612913



##########
File path: website/www/site/content/en/documentation/programming-guide.md
##########
@@ -2150,9 +2149,11 @@ class ProcessRecord(beam.DoFn):
 {{< /highlight >}}
 
 {{< highlight go >}}
-// PaneInfo and triggers are not yet implemented in the Go SDK.
-// See https://issues.apache.org/jira/browse/BEAM-3304 for info
-// on contributing triggers and panes.
+func MyDoFn(pn beam.PaneInfo, word string) string {
+  t := int(pn.timing)
+  isFirstPane, isLastPane := pn.IsFirst, pn.IsLast
+  ...
+}

Review comment:
       Can we move this into the Go snippets folder (see https://github.com/apache/beam/pull/17048/files for an example). That has the benefit of (a) keeping our code samples in a predictable place and (b) making sure they continue to compile (a free small extra layer of testing)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org