You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "MartijnVisser (via GitHub)" <gi...@apache.org> on 2023/12/13 10:02:22 UTC
[PR] [FLINK-33603][Filesystem] Bundle Guava for GCS connector [flink]
MartijnVisser opened a new pull request, #23920:
URL: https://github.com/apache/flink/pull/23920
## What is the purpose of the change
* Resolve FLINK-33793 `java.lang.NoSuchMethodError when checkpointing in Google Cloud Storage`
## Brief change log
* Make sure that Guava is bundled for GCS connector
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33603][Filesystem] Bundle Guava for GCS connector [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23920:
URL: https://github.com/apache/flink/pull/23920#issuecomment-1853622776
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ebe7f6e090690486c1954099a2b57283c578192",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2ebe7f6e090690486c1954099a2b57283c578192",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ebe7f6e090690486c1954099a2b57283c578192 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33603][1.18][Filesystem] Bundle Guava for GCS connector [flink]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #23920:
URL: https://github.com/apache/flink/pull/23920#issuecomment-1859733229
Superseded by https://issues.apache.org/jira/browse/FLINK-33704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33603][Filesystem] Bundle Guava for GCS connector [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #23920:
URL: https://github.com/apache/flink/pull/23920#discussion_r1426753864
##########
flink-filesystems/flink-gs-fs-hadoop/src/main/resources/META-INF/NOTICE:
##########
@@ -32,6 +32,7 @@ This project bundles the following dependencies under the Apache Software Licens
- com.google.flogger:flogger-system-backend:0.7.1
- com.google.flogger:flogger:0.7.1
- com.google.flogger:google-extensions:0.7.1
+- com.google.guava:guava:31.1-jre
Review Comment:
is it ok to hava guava 31.1 here if current google-cloud-storage depends on 32.1.2 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33603][1.18][Filesystem] Bundle Guava for GCS connector [flink]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser closed pull request #23920: [FLINK-33603][1.18][Filesystem] Bundle Guava for GCS connector
URL: https://github.com/apache/flink/pull/23920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33603][Filesystem] Bundle Guava for GCS connector [flink]
Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe commented on PR #23920:
URL: https://github.com/apache/flink/pull/23920#issuecomment-1855980170
please see my comment in the original PR: https://github.com/apache/flink/pull/23489#issuecomment-1854677694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33603][Filesystem] Bundle Guava for GCS connector [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #23920:
URL: https://github.com/apache/flink/pull/23920#discussion_r1426753864
##########
flink-filesystems/flink-gs-fs-hadoop/src/main/resources/META-INF/NOTICE:
##########
@@ -32,6 +32,7 @@ This project bundles the following dependencies under the Apache Software Licens
- com.google.flogger:flogger-system-backend:0.7.1
- com.google.flogger:flogger:0.7.1
- com.google.flogger:google-extensions:0.7.1
+- com.google.guava:guava:31.1-jre
Review Comment:
is it ok to have guava 31.1 here if current google-cloud-storage depends on 32.1.2 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org