You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yongqiao Wang <yq...@cn.ibm.com> on 2016/03/23 09:32:49 UTC
Review Request 45202: Add test for rescinding offer trriggered by
updating weights.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45202/
-----------------------------------------------------------
Review request for mesos and Adam B.
Bugs: MESOS-4881
https://issues.apache.org/jira/browse/MESOS-4881
Repository: mesos
Description
-------
Add test for rescinding offer trriggered by updating weights.
Diffs
-----
src/tests/dynamic_weights_tests.cpp ee0c4b1cc20e76a35a8e4e445f6827a1fc33e6c6
src/tests/master_allocator_tests.cpp b41ba2bda4d680f6fc42f525719973d56c11fe31
src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57
Diff: https://reviews.apache.org/r/45202/diff/
Testing
-------
make && make check.
$ ./src/mesos-tests --gtest_filter=MasterAllocatorTest/0.RebalancedForUpdatedWeights
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter> >
[ RUN ] MasterAllocatorTest/0.RebalancedForUpdatedWeights
[ OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (1059 ms)
[----------] 1 test from MasterAllocatorTest/0 (1059 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1070 ms total)
[ PASSED ] 1 test.
Thanks,
Yongqiao Wang
Re: Review Request 45202: Add test for rescinding offer trriggered by
updating weights.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45202/#review125395
-----------------------------------------------------------
Great test for the rescind patch! Just a few cleanup suggestions
src/tests/master_allocator_tests.cpp (lines 1559 - 1561)
<https://reviews.apache.org/r/45202/#comment188183>
You could just check
```
EXPECT_EQ(Resources(framework1offers1.get()[i].resources()),
Resources::parse(slaveFlags.resources.get()).get());
```
Then you're not planting magic numbers (2, 1024) all over the code.
src/tests/master_allocator_tests.cpp (line 1591)
<https://reviews.apache.org/r/45202/#comment188187>
Why "AtMost" instead of just `3`?
src/tests/master_allocator_tests.cpp (lines 1616 - 1618)
<https://reviews.apache.org/r/45202/#comment188188>
same as above
src/tests/master_allocator_tests.cpp (lines 1623 - 1625)
<https://reviews.apache.org/r/45202/#comment188189>
same as above
src/tests/mesos.hpp (lines 669 - 673)
<https://reviews.apache.org/r/45202/#comment188182>
Couldn't this just be:
`return strings::format("%s", JSON::protobuf(infos)).get();`?
And for that matter, is
`createUpdateRequestBody(infos)`
so much shorter than
`strings::format("%s", JSON::protobuf(infos)).get()`
that it really needs to be its own function? I don't think think so. Just inline this everywhere. Example:
```
RepeatedPtrField<WeightInfo>& infos = createWeightInfos("role1=0");
Future<Response> response = process::http::request(
process::http::createRequest(
master.get()->pid,
"PUT",
false,
"weights",
createBasicAuthHeaders(DEFAULT_CREDENTIAL),
strings::format("%s", JSON::protobuf(infos)).get()));
```
- Adam B
On March 23, 2016, 1:32 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45202/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 1:32 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-4881
> https://issues.apache.org/jira/browse/MESOS-4881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add test for rescinding offer trriggered by updating weights.
>
>
> Diffs
> -----
>
> src/tests/dynamic_weights_tests.cpp ee0c4b1cc20e76a35a8e4e445f6827a1fc33e6c6
> src/tests/master_allocator_tests.cpp b41ba2bda4d680f6fc42f525719973d56c11fe31
> src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57
>
> Diff: https://reviews.apache.org/r/45202/diff/
>
>
> Testing
> -------
>
> make && make check.
>
> $ ./src/mesos-tests --gtest_filter=MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter> >
> [ RUN ] MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [ OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (1059 ms)
> [----------] 1 test from MasterAllocatorTest/0 (1059 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1070 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 45202: Add test for rescinding offer trriggered by
updating weights.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45202/#review126281
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45202]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 31, 2016, 7:15 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45202/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 7:15 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-4881
> https://issues.apache.org/jira/browse/MESOS-4881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add test for rescinding offer trriggered by updating weights.
>
>
> Diffs
> -----
>
> src/tests/dynamic_weights_tests.cpp 6357cf42ec59c1388e95d6d808978918d5cd4a78
> src/tests/master_allocator_tests.cpp b41ba2bda4d680f6fc42f525719973d56c11fe31
> src/tests/mesos.hpp a35371d7c1fcb9dbbe8a18c80522deb6bf789ad8
>
> Diff: https://reviews.apache.org/r/45202/diff/
>
>
> Testing
> -------
>
> make && make check.
>
> $ ./src/mesos-tests --gtest_filter=MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter> >
> [ RUN ] MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [ OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (1059 ms)
> [----------] 1 test from MasterAllocatorTest/0 (1059 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1070 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 45202: Add test for rescinding offer trriggered by
updating weights.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45202/
-----------------------------------------------------------
(Updated March 31, 2016, 7:15 a.m.)
Review request for mesos and Adam B.
Changes
-------
Addressed comments of adam.
Bugs: MESOS-4881
https://issues.apache.org/jira/browse/MESOS-4881
Repository: mesos
Description
-------
Add test for rescinding offer trriggered by updating weights.
Diffs (updated)
-----
src/tests/dynamic_weights_tests.cpp 6357cf42ec59c1388e95d6d808978918d5cd4a78
src/tests/master_allocator_tests.cpp b41ba2bda4d680f6fc42f525719973d56c11fe31
src/tests/mesos.hpp a35371d7c1fcb9dbbe8a18c80522deb6bf789ad8
Diff: https://reviews.apache.org/r/45202/diff/
Testing
-------
make && make check.
$ ./src/mesos-tests --gtest_filter=MasterAllocatorTest/0.RebalancedForUpdatedWeights
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter> >
[ RUN ] MasterAllocatorTest/0.RebalancedForUpdatedWeights
[ OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (1059 ms)
[----------] 1 test from MasterAllocatorTest/0 (1059 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1070 ms total)
[ PASSED ] 1 test.
Thanks,
Yongqiao Wang
Re: Review Request 45202: Add test for rescinding offer trriggered by
updating weights.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45202/#review125437
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44450, 45202]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 25, 2016, 9:13 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45202/
> -----------------------------------------------------------
>
> (Updated March 25, 2016, 9:13 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-4881
> https://issues.apache.org/jira/browse/MESOS-4881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add test for rescinding offer trriggered by updating weights.
>
>
> Diffs
> -----
>
> src/tests/dynamic_weights_tests.cpp 6357cf42ec59c1388e95d6d808978918d5cd4a78
> src/tests/master_allocator_tests.cpp b41ba2bda4d680f6fc42f525719973d56c11fe31
> src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57
>
> Diff: https://reviews.apache.org/r/45202/diff/
>
>
> Testing
> -------
>
> make && make check.
>
> $ ./src/mesos-tests --gtest_filter=MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter> >
> [ RUN ] MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [ OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (1059 ms)
> [----------] 1 test from MasterAllocatorTest/0 (1059 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1070 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 45202: Add test for rescinding offer trriggered by
updating weights.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
> On March 30, 2016, 11:58 a.m., Adam B wrote:
> > src/tests/master_allocator_tests.cpp, line 1519
> > <https://reviews.apache.org/r/45202/diff/2/?file=1314587#file1314587line1519>
> >
> > Don't you at least know that one of these parameters is the master's pid?
Do you mean the parameters of addSlave function in allocator interface? if yes, then master's pid is not one of them. Cloud you help to make this comment clearly? Thanks.
- Yongqiao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45202/#review126083
-----------------------------------------------------------
On March 25, 2016, 9:13 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45202/
> -----------------------------------------------------------
>
> (Updated March 25, 2016, 9:13 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-4881
> https://issues.apache.org/jira/browse/MESOS-4881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add test for rescinding offer trriggered by updating weights.
>
>
> Diffs
> -----
>
> src/tests/dynamic_weights_tests.cpp 6357cf42ec59c1388e95d6d808978918d5cd4a78
> src/tests/master_allocator_tests.cpp b41ba2bda4d680f6fc42f525719973d56c11fe31
> src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57
>
> Diff: https://reviews.apache.org/r/45202/diff/
>
>
> Testing
> -------
>
> make && make check.
>
> $ ./src/mesos-tests --gtest_filter=MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter> >
> [ RUN ] MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [ OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (1059 ms)
> [----------] 1 test from MasterAllocatorTest/0 (1059 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1070 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 45202: Add test for rescinding offer trriggered by
updating weights.
Posted by Adam B <ad...@mesosphere.io>.
> On March 30, 2016, 4:58 a.m., Adam B wrote:
> > src/tests/master_allocator_tests.cpp, line 1519
> > <https://reviews.apache.org/r/45202/diff/2/?file=1314587#file1314587line1519>
> >
> > Don't you at least know that one of these parameters is the master's pid?
>
> Yongqiao Wang wrote:
> Do you mean the parameters of addSlave function in allocator interface? if yes, then master's pid is not one of them. Cloud you help to make this comment clearly? Thanks.
Nevermind. Dropping. I just meant that all those `_`s you're filling in as parameters act as wildcards, and if there's something we definitely know (e.g. master pid), it'd be better to explicitly match against that instead of the wildcard. But I realize now that this is not an EXPECT_PROTOBUF or EXPECT_MESSAGE where one of the parameters is the 'from' pid, but rather this is an EXPECT_CALL, and everybody seems to pass it all `_`s.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45202/#review126083
-----------------------------------------------------------
On March 31, 2016, 12:15 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45202/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 12:15 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-4881
> https://issues.apache.org/jira/browse/MESOS-4881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add test for rescinding offer trriggered by updating weights.
>
>
> Diffs
> -----
>
> src/tests/dynamic_weights_tests.cpp 6357cf42ec59c1388e95d6d808978918d5cd4a78
> src/tests/master_allocator_tests.cpp b41ba2bda4d680f6fc42f525719973d56c11fe31
> src/tests/mesos.hpp a35371d7c1fcb9dbbe8a18c80522deb6bf789ad8
>
> Diff: https://reviews.apache.org/r/45202/diff/
>
>
> Testing
> -------
>
> make && make check.
>
> $ ./src/mesos-tests --gtest_filter=MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter> >
> [ RUN ] MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [ OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (1059 ms)
> [----------] 1 test from MasterAllocatorTest/0 (1059 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1070 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 45202: Add test for rescinding offer trriggered by
updating weights.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45202/#review126083
-----------------------------------------------------------
Fix it, then Ship it!
Some minor style suggestions, and then we can commit this too.
src/tests/dynamic_weights_tests.cpp (line 467)
<https://reviews.apache.org/r/45202/#comment188992>
s/UPDATED_WEIGHTS/UPDATED_WEIGHTS1/
src/tests/dynamic_weights_tests.cpp (line 498)
<https://reviews.apache.org/r/45202/#comment188993>
s/UPDATED_WEIGHTS/UPDATED_WEIGHTS1/
src/tests/dynamic_weights_tests.cpp (line 550)
<https://reviews.apache.org/r/45202/#comment188994>
UPDATED_WEIGHTS1
src/tests/dynamic_weights_tests.cpp (line 590)
<https://reviews.apache.org/r/45202/#comment188995>
UPDATED_WEIGHTS1
src/tests/dynamic_weights_tests.cpp (line 622)
<https://reviews.apache.org/r/45202/#comment188996>
UPDATED_WEIGHTS1
src/tests/master_allocator_tests.cpp (line 1519)
<https://reviews.apache.org/r/45202/#comment188997>
Don't you at least know that one of these parameters is the master's pid?
src/tests/master_allocator_tests.cpp (line 1524)
<https://reviews.apache.org/r/45202/#comment188998>
You should be able to assign the string directly with `flags.resources = agentResources;` and the Option constructor will handle conversion
src/tests/master_allocator_tests.cpp (lines 1593 - 1595)
<https://reviews.apache.org/r/45202/#comment188999>
Set `using` statements at the beginning of the file so we don't need to have the entire namespace here for each class
- Adam B
On March 25, 2016, 2:13 a.m., Yongqiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45202/
> -----------------------------------------------------------
>
> (Updated March 25, 2016, 2:13 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-4881
> https://issues.apache.org/jira/browse/MESOS-4881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add test for rescinding offer trriggered by updating weights.
>
>
> Diffs
> -----
>
> src/tests/dynamic_weights_tests.cpp 6357cf42ec59c1388e95d6d808978918d5cd4a78
> src/tests/master_allocator_tests.cpp b41ba2bda4d680f6fc42f525719973d56c11fe31
> src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57
>
> Diff: https://reviews.apache.org/r/45202/diff/
>
>
> Testing
> -------
>
> make && make check.
>
> $ ./src/mesos-tests --gtest_filter=MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter> >
> [ RUN ] MasterAllocatorTest/0.RebalancedForUpdatedWeights
> [ OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (1059 ms)
> [----------] 1 test from MasterAllocatorTest/0 (1059 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1070 ms total)
> [ PASSED ] 1 test.
>
>
> Thanks,
>
> Yongqiao Wang
>
>
Re: Review Request 45202: Add test for rescinding offer trriggered by
updating weights.
Posted by Yongqiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45202/
-----------------------------------------------------------
(Updated March 25, 2016, 9:13 a.m.)
Review request for mesos and Adam B.
Changes
-------
Addressed the comments of adam.
Bugs: MESOS-4881
https://issues.apache.org/jira/browse/MESOS-4881
Repository: mesos
Description
-------
Add test for rescinding offer trriggered by updating weights.
Diffs (updated)
-----
src/tests/dynamic_weights_tests.cpp 6357cf42ec59c1388e95d6d808978918d5cd4a78
src/tests/master_allocator_tests.cpp b41ba2bda4d680f6fc42f525719973d56c11fe31
src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57
Diff: https://reviews.apache.org/r/45202/diff/
Testing
-------
make && make check.
$ ./src/mesos-tests --gtest_filter=MasterAllocatorTest/0.RebalancedForUpdatedWeights
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from MasterAllocatorTest/0, where TypeParam = mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter, mesos::internal::master::allocator::DRFSorter> >
[ RUN ] MasterAllocatorTest/0.RebalancedForUpdatedWeights
[ OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (1059 ms)
[----------] 1 test from MasterAllocatorTest/0 (1059 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1070 ms total)
[ PASSED ] 1 test.
Thanks,
Yongqiao Wang