Compile failure

[Rasmus Lerdorf <ra...@lerdorf.on.ca>]

Current CVS is not compiling.  Someone forgot an argument to
ap_call_exec() in mod_include.c:

gcc -c  -I../../os/unix -I../../include   -DSOLARIS2=260 -DUSE_HSREGEX
-DSERVER_SUBVERSION=\"PHP/3.0R-Dev\"  mod_include.c
mod_include.c: In function `include_cmd_child':
mod_include.c:789: warning: passing arg 2 of `ap_call_exec' from
incompatible pointer type
mod_include.c:789: warning: passing arg 3 of `ap_call_exec' from
incompatible pointer type
mod_include.c:789: warning: passing arg 4 of `ap_call_exec' makes pointer
from integer without a cast
mod_include.c:789: too few arguments to function `ap_call_exec'

In mod_cgi we call it with 5 arguments:
mod_cgi.c:    child_pid = ap_call_exec(r, pinfo, argv0, env, 0);

and in mod_include only with 4:
mod_include.c:    child_pid = ap_call_exec(r,s,ap_create_environment(r->pool, env), 1);

Looks like argv0 is missing in mod_include.

-Rasmus

Re: Compile failure

[Ben Laurie <be...@algroup.co.uk>]

Rasmus Lerdorf wrote:
> 
> Current CVS is not compiling.  Someone forgot an argument to
> ap_call_exec() in mod_include.c:
> 
> gcc -c  -I../../os/unix -I../../include   -DSOLARIS2=260 -DUSE_HSREGEX
> -DSERVER_SUBVERSION=\"PHP/3.0R-Dev\"  mod_include.c
> mod_include.c: In function `include_cmd_child':
> mod_include.c:789: warning: passing arg 2 of `ap_call_exec' from
> incompatible pointer type
> mod_include.c:789: warning: passing arg 3 of `ap_call_exec' from
> incompatible pointer type
> mod_include.c:789: warning: passing arg 4 of `ap_call_exec' makes pointer
> from integer without a cast
> mod_include.c:789: too few arguments to function `ap_call_exec'
> 
> In mod_cgi we call it with 5 arguments:
> mod_cgi.c:    child_pid = ap_call_exec(r, pinfo, argv0, env, 0);
> 
> and in mod_include only with 4:
> mod_include.c:    child_pid = ap_call_exec(r,s,ap_create_environment(r->pool, env), 1);
> 
> Looks like argv0 is missing in mod_include.

Nah. What is missing is the new pinfo - give it a NULL for now:

child_pid = ap_call_exec(r,NULL,s,ap_create_environment(r->pool, env),
1);

which will do until someone fixes it for Win32...

Cheers,

Ben.

-- 
Ben Laurie            |Phone: +44 (181) 735 0686|  Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |
A.L. Digital Ltd,     |Apache-SSL author    http://www.apache-ssl.org/
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache