You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/13 15:29:06 UTC

[GitHub] [superset] diegomedina248 commented on a diff in pull request #19692: feat: Update ShortKey for stop query running in SqlLab editor

diegomedina248 commented on code in PR #19692:
URL: https://github.com/apache/superset/pull/19692#discussion_r849619990


##########
superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx:
##########
@@ -114,7 +117,9 @@ const RunQueryActionButton = ({
         tooltip={
           (!isDisabled &&
             (shouldShowStopBtn
-              ? t('Stop running (Ctrl + x)')
+              ? userOS === 'MacOS'

Review Comment:
   we could move this to a memo, or even a plain function outside of the component called `getStopButtonTooltipText` or something.. Seems too much inline ifs for my liking here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org