You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/03/13 21:26:52 UTC

Review Request 19202: Add killall functionality to clientv2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19202/
-----------------------------------------------------------

Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: aurora-260
    https://issues.apache.org/jira/browse/aurora-260


Repository: aurora


Description
-------

Add killall functionality to clientv2

- Make the "job kill" command require an instances parameter.
- Add a new command, "job killall", which generates a scary warning
  message and delay before actually killing.


Diffs
-----

  src/main/python/apache/aurora/client/cli/jobs.py b9d4e8305a975d93cf4f024e70bfb9798762d6d7 
  src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa 

Diff: https://reviews.apache.org/r/19202/diff/


Testing
-------

Updated unit tests and added new cases; all pass.


Thanks,

Mark Chu-Carroll