You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Stefan Bodewig <bo...@apache.org> on 2013/08/07 17:15:53 UTC
Re: svn commit: r1511326 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/dump/ main/java/org/apache/commons/compress/compressors/bzip2/ test/java/org/apache/commons/compress/
On 2013-08-07, <eb...@apache.org> wrote:
> - public BZip2CompressorInputStream(final InputStream in,
> - final boolean decompressConcatenated)
> - throws IOException {
> -
> + public BZip2CompressorInputStream(final InputStream in, final boolean decompressConcatenated) throws IOException {
I'm not sure whether we have any policy on this, but so far I've tried
to stick with 80 columns max. Maybe that's a sign of me being old
fashioned, don't know :-)
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1511326 - in /commons/proper/compress/trunk/src:
main/java/org/apache/commons/compress/archivers/dump/ main/java/org/apache/commons/compress/compressors/bzip2/
test/java/org/apache/commons/compress/
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Aug 7, 2013 at 11:15 AM, Stefan Bodewig <bo...@apache.org> wrote:
> On 2013-08-07, <eb...@apache.org> wrote:
>
> > - public BZip2CompressorInputStream(final InputStream in,
> > - final boolean
> decompressConcatenated)
> > - throws IOException {
> > -
> > + public BZip2CompressorInputStream(final InputStream in, final
> boolean decompressConcatenated) throws IOException {
>
> I'm not sure whether we have any policy on this, but so far I've tried
> to stick with 80 columns max. Maybe that's a sign of me being old
> fashioned, don't know :-)
>
A line length of 120 is common in a lot of Commons components. 120 is
enforced by Checkstyle in some projects. I suggest you do the same here! :)
Gary
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: svn commit: r1511326 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/dump/ main/java/org/apache/commons/compress/compressors/bzip2/ test/java/org/apache/commons/compress/
Posted by Stefan Bodewig <bo...@apache.org>.
On 2013-08-07, Emmanuel Bourg wrote:
> Le 07/08/2013 17:15, Stefan Bodewig a écrit :
>> I'm not sure whether we have any policy on this, but so far I've tried
>> to stick with 80 columns max. Maybe that's a sign of me being old
>> fashioned, don't know :-)
> 80 columns is quite restrictive with today's wide screens and often
> cause excessive wrapping. I usually restrain myself to 120 columns for
> the code and 80 columns for comments.
> Feel free to reformat as you like, you are reading this code more
> frequently than I do.
I can read either. If 120 is common among other components, then I can
live with that.
Thanks
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1511326 - in /commons/proper/compress/trunk/src:
main/java/org/apache/commons/compress/archivers/dump/ main/java/org/apache/commons/compress/compressors/bzip2/
test/java/org/apache/commons/compress/
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 07/08/2013 17:15, Stefan Bodewig a écrit :
> I'm not sure whether we have any policy on this, but so far I've tried
> to stick with 80 columns max. Maybe that's a sign of me being old
> fashioned, don't know :-)
80 columns is quite restrictive with today's wide screens and often
cause excessive wrapping. I usually restrain myself to 120 columns for
the code and 80 columns for comments.
Feel free to reformat as you like, you are reading this code more
frequently than I do.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org