You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/08 06:47:07 UTC

[GitHub] [flink] TisonKun opened a new pull request #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan

TisonKun opened a new pull request #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan
URL: https://github.com/apache/flink/pull/10795
 
 
   ## What is the purpose of the change
   
   Currently we print StreamGraph JSON as string without pretty printer. The output is less than awesome. We can simply switch to `toPrettyString`.
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan
URL: https://github.com/apache/flink/pull/10795#issuecomment-571915336
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 989a1cfecbe74568d9fc4508a884eddfb4f990a2 (Wed Jan 08 06:50:18 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan
URL: https://github.com/apache/flink/pull/10795#issuecomment-571921686
 
 
   <!--
   Meta data
   Hash:989a1cfecbe74568d9fc4508a884eddfb4f990a2 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143517107 TriggerType:PUSH TriggerID:989a1cfecbe74568d9fc4508a884eddfb4f990a2
   Hash:989a1cfecbe74568d9fc4508a884eddfb4f990a2 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4180 TriggerType:PUSH TriggerID:989a1cfecbe74568d9fc4508a884eddfb4f990a2
   -->
   ## CI report:
   
   * 989a1cfecbe74568d9fc4508a884eddfb4f990a2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143517107) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4180) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] TisonKun commented on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan

Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan
URL: https://github.com/apache/flink/pull/10795#issuecomment-572005908
 
 
   note the difference introduced by the first commit which change `toString` with `toPrettyString`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan
URL: https://github.com/apache/flink/pull/10795#issuecomment-571921686
 
 
   <!--
   Meta data
   Hash:989a1cfecbe74568d9fc4508a884eddfb4f990a2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143517107 TriggerType:PUSH TriggerID:989a1cfecbe74568d9fc4508a884eddfb4f990a2
   Hash:989a1cfecbe74568d9fc4508a884eddfb4f990a2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4180 TriggerType:PUSH TriggerID:989a1cfecbe74568d9fc4508a884eddfb4f990a2
   -->
   ## CI report:
   
   * 989a1cfecbe74568d9fc4508a884eddfb4f990a2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143517107) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4180) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan
URL: https://github.com/apache/flink/pull/10795#issuecomment-571921686
 
 
   <!--
   Meta data
   Hash:989a1cfecbe74568d9fc4508a884eddfb4f990a2 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:989a1cfecbe74568d9fc4508a884eddfb4f990a2
   -->
   ## CI report:
   
   * 989a1cfecbe74568d9fc4508a884eddfb4f990a2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] TisonKun commented on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan

Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan
URL: https://github.com/apache/flink/pull/10795#issuecomment-572027259
 
 
   Thanks for your review!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] TisonKun commented on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan

Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan
URL: https://github.com/apache/flink/pull/10795#issuecomment-572005702
 
 
   Thanks for your attention @aljoscha ! The difference is as below.
   
   Before:
   
   ![image](https://user-images.githubusercontent.com/18818196/71971261-3580ff00-3245-11ea-983a-b9330c6952a6.png)
   
   After:
   
   ![image](https://user-images.githubusercontent.com/18818196/71974124-a9bea100-324b-11ea-99e3-f7118539820e.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan
URL: https://github.com/apache/flink/pull/10795#issuecomment-571921686
 
 
   <!--
   Meta data
   Hash:989a1cfecbe74568d9fc4508a884eddfb4f990a2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143517107 TriggerType:PUSH TriggerID:989a1cfecbe74568d9fc4508a884eddfb4f990a2
   Hash:989a1cfecbe74568d9fc4508a884eddfb4f990a2 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4180 TriggerType:PUSH TriggerID:989a1cfecbe74568d9fc4508a884eddfb4f990a2
   -->
   ## CI report:
   
   * 989a1cfecbe74568d9fc4508a884eddfb4f990a2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143517107) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4180) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha merged pull request #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan

Posted by GitBox <gi...@apache.org>.
aljoscha merged pull request #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan
URL: https://github.com/apache/flink/pull/10795
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] aljoscha commented on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan

Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #10795: [FLINK-15510] Pretty Print StreamGraph JSON Plan
URL: https://github.com/apache/flink/pull/10795#issuecomment-572026280
 
 
   Oh yes, that's a night and day difference. Immediately merged! 🍵 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services