You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "buraksenn (via GitHub)" <gi...@apache.org> on 2026/07/22 09:37:58 UTC
[PR] refactor(proto): migrate SortExec and SortPreservingMergeExec serde [datafusion]
buraksenn opened a new pull request, #23794:
URL: https://github.com/apache/datafusion/pull/23794
## Which issue does this PR close?
- Closes #23505.
## Rationale for this change
Part of epic #23494. Moves `SortExec` and `SortPreservingMergeExec` protobuf serialization from central dispatch.
## What changes are included in this PR?
Add protobuf serialization and deserialization to the physical plan implementations and deprecate the corresponding central proto methods. The wire format remains unchanged.
## Are these changes tested?
Yes, existing round-trip tests cover these plans.
## Are there any user-facing changes?
Existing methods are deprecated with no immediate API change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor(proto): migrate SortExec and SortPreservingMergeExec serde [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb merged PR #23794:
URL: https://github.com/apache/datafusion/pull/23794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor(proto): migrate SortExec and SortPreservingMergeExec serde [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23794:
URL: https://github.com/apache/datafusion/pull/23794#issuecomment-5044911384
<!-- semver-check-comment -->
Thank you for opening this pull request!
Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).
<details>
<summary>Details</summary>
```
Cloning apache/main
Building datafusion-physical-plan v54.1.0 (current)
Built [ 40.629s] (current)
Parsing datafusion-physical-plan v54.1.0 (current)
Parsed [ 0.141s] (current)
Building datafusion-physical-plan v54.1.0 (baseline)
Built [ 36.317s] (baseline)
Parsing datafusion-physical-plan v54.1.0 (baseline)
Parsed [ 0.141s] (baseline)
Checking datafusion-physical-plan v54.1.0 -> v54.1.0 (no change; assume patch)
Checked [ 0.596s] 223 checks: 223 pass, 30 skip
Summary no semver update required
Finished [ 79.530s] datafusion-physical-plan
Building datafusion-proto v54.1.0 (current)
Built [ 59.114s] (current)
Parsing datafusion-proto v54.1.0 (current)
Parsed [ 0.019s] (current)
Building datafusion-proto v54.1.0 (baseline)
Built [ 60.601s] (baseline)
Parsing datafusion-proto v54.1.0 (baseline)
Parsed [ 0.020s] (baseline)
Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch)
Checked [ 0.266s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip
--- failure trait_method_marked_deprecated: trait method #[deprecated] added ---
Description:
A trait method is now #[deprecated]. Downstream crates will get a compiler warning when using this method.
ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_method_marked_deprecated.ron
Failed in:
method try_into_sort_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:722
method try_into_sort_preserving_merge_physical_plan in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:722
method try_from_sort_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:722
method try_from_sort_preserving_merge_exec in trait datafusion_proto::physical_plan::PhysicalPlanNodeExt in /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:722
Summary semver requires new minor version: 0 major and 1 minor checks failed
Finished [ 121.297s] datafusion-proto
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org