You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/07/12 01:01:04 UTC
[GitHub] [tinkerpop] xiazcy opened a new pull request, #1753: Gremlin-Go: Fixed bug for GHA, increased server wait retries & fixed traversal int casting
xiazcy opened a new pull request, #1753:
URL: https://github.com/apache/tinkerpop/pull/1753
GHA was not capturing the exit code from `docker-compose up` b/c `docker-compose down` was on separate lines. Now GHA should correctly capture failed golang tests.
Fixed the failing golang test related to recent [PR](https://github.com/apache/tinkerpop/pull/1743) as a result of the above mistake.
Doubled the wait-for-server retry count as sometimes neo4j takes longer to get installed in GHA, to prevent premature exit of the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] jroimartin commented on a diff in pull request #1753: Gremlin-Go: Fixed bug for GHA, increased server wait retries & fixed traversal int casting
Posted by GitBox <gi...@apache.org>.
jroimartin commented on code in PR #1753:
URL: https://github.com/apache/tinkerpop/pull/1753#discussion_r918465921
##########
gremlin-go/run.sh:
##########
@@ -44,7 +44,5 @@ GREMLIN_SERVER_VERSION=$(grep tinkerpop -A2 pom.xml | grep -Po '(?<=<version>)([
export GREMLIN_SERVER="${1:-$GREMLIN_SERVER_VERSION}"
echo "$GREMLIN_SERVER"
-# Passes current gremlin server version into docker compose as environment variable
-docker-compose up --build --exit-code-from gremlin-go-integration-tests
-# Removes all service containers
-docker-compose down
+# Passes current gremlin server version into docker compose as environment variable & removes all service containers
+docker-compose up --build --abort-on-container-exit --exit-code-from gremlin-go-integration-tests && docker-compose down
Review Comment:
Do we really need `docker-compose down` if we abort on container exit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] jroimartin commented on a diff in pull request #1753: Gremlin-Go: Fixed bug for GHA, increased server wait retries & fixed traversal int casting
Posted by GitBox <gi...@apache.org>.
jroimartin commented on code in PR #1753:
URL: https://github.com/apache/tinkerpop/pull/1753#discussion_r918465921
##########
gremlin-go/run.sh:
##########
@@ -44,7 +44,5 @@ GREMLIN_SERVER_VERSION=$(grep tinkerpop -A2 pom.xml | grep -Po '(?<=<version>)([
export GREMLIN_SERVER="${1:-$GREMLIN_SERVER_VERSION}"
echo "$GREMLIN_SERVER"
-# Passes current gremlin server version into docker compose as environment variable
-docker-compose up --build --exit-code-from gremlin-go-integration-tests
-# Removes all service containers
-docker-compose down
+# Passes current gremlin server version into docker compose as environment variable & removes all service containers
+docker-compose up --build --abort-on-container-exit --exit-code-from gremlin-go-integration-tests && docker-compose down
Review Comment:
Do we really need `docker-compose down` if we abort on container exit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #1753: Gremlin-Go: Fixed bug for GHA, increased server wait retries & fixed traversal int casting
Posted by GitBox <gi...@apache.org>.
spmallette merged PR #1753:
URL: https://github.com/apache/tinkerpop/pull/1753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1753: Gremlin-Go: Fixed bug for GHA, increased server wait retries & fixed traversal int casting
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1753:
URL: https://github.com/apache/tinkerpop/pull/1753#issuecomment-1181206686
# [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1753?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1753](https://codecov.io/gh/apache/tinkerpop/pull/1753?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f664040) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/89669451ed1322a03e0e5c551367511d22322f27?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8966945) will **increase** coverage by `21.09%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## 3.5-dev #1753 +/- ##
============================================
+ Coverage 42.39% 63.48% +21.09%
============================================
Files 23 23
Lines 3640 3640
============================================
+ Hits 1543 2311 +768
+ Misses 1937 1150 -787
- Partials 160 179 +19
```
| [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [gremlin-go/driver/graphTraversal.go](https://codecov.io/gh/apache/tinkerpop/pull/1753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZ3JhcGhUcmF2ZXJzYWwuZ28=) | `87.01% <100.00%> (+16.82%)` | :arrow_up: |
| [gremlin-go/driver/serializer.go](https://codecov.io/gh/apache/tinkerpop/pull/1753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvc2VyaWFsaXplci5nbw==) | `63.90% <0.00%> (+3.90%)` | :arrow_up: |
| [gremlin-go/driver/gorillaTransporter.go](https://codecov.io/gh/apache/tinkerpop/pull/1753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZ29yaWxsYVRyYW5zcG9ydGVyLmdv) | `64.54% <0.00%> (+9.09%)` | :arrow_up: |
| [gremlin-go/driver/error\_codes.go](https://codecov.io/gh/apache/tinkerpop/pull/1753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZXJyb3JfY29kZXMuZ28=) | `100.00% <0.00%> (+10.52%)` | :arrow_up: |
| [gremlin-go/driver/traversal.go](https://codecov.io/gh/apache/tinkerpop/pull/1753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvdHJhdmVyc2FsLmdv) | `70.54% <0.00%> (+10.85%)` | :arrow_up: |
| [gremlin-go/driver/resultSet.go](https://codecov.io/gh/apache/tinkerpop/pull/1753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcmVzdWx0U2V0Lmdv) | `80.18% <0.00%> (+11.32%)` | :arrow_up: |
| [gremlin-go/driver/graphTraversalSource.go](https://codecov.io/gh/apache/tinkerpop/pull/1753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZ3JhcGhUcmF2ZXJzYWxTb3VyY2UuZ28=) | `85.71% <0.00%> (+12.08%)` | :arrow_up: |
| [gremlin-go/driver/connection.go](https://codecov.io/gh/apache/tinkerpop/pull/1753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvY29ubmVjdGlvbi5nbw==) | `80.00% <0.00%> (+15.71%)` | :arrow_up: |
| [gremlin-go/driver/connectionPool.go](https://codecov.io/gh/apache/tinkerpop/pull/1753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvY29ubmVjdGlvblBvb2wuZ28=) | `71.84% <0.00%> (+16.50%)` | :arrow_up: |
| [gremlin-go/driver/graphBinary.go](https://codecov.io/gh/apache/tinkerpop/pull/1753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZ3JhcGhCaW5hcnkuZ28=) | `54.23% <0.00%> (+16.52%)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/tinkerpop/pull/1753/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1753?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1753?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8966945...f664040](https://codecov.io/gh/apache/tinkerpop/pull/1753?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] jroimartin commented on pull request #1753: Gremlin-Go: Fixed bug for GHA, increased server wait retries & fixed traversal int casting
Posted by GitBox <gi...@apache.org>.
jroimartin commented on PR #1753:
URL: https://github.com/apache/tinkerpop/pull/1753#issuecomment-1181222218
LGTM. Good catch with https://github.com/apache/tinkerpop/pull/1743!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org