You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "miinhho (via GitHub)" <gi...@apache.org> on 2026/09/13 08:09:27 UTC
[PR] [ZEPPELIN-6517] Add E2E tests for notebook paragraph components [zeppelin]
miinhho opened a new pull request, #5476:
URL: https://github.com/apache/zeppelin/pull/5476
### What is this PR for?
This PR improves the behavior-focused E2E coverage for the notebook paragraph sub-components.
It replaces shallow visibility checks and interpreter-error fallbacks with scenarios that verify user-observable paragraph behavior:
- Add paragraphs above and below the current paragraph
- Edit Monaco content and verify focused, dirty, and rendered line states
- Inspect the paragraph settings available for single and multiple paragraphs
- Clone, insert, move, and remove paragraphs
- Toggle the editor, output, line numbers, and run state
- Edit paragraph titles and verify Enter, Escape, and blur behavior
- Verify running, finished, outdated, and cancelled paragraph states
- Verify progress and footer timing information
- Verify that paragraph insertion is disabled while execution is in progress
The paragraph page object is also updated to:
- Scope component locators to the primary paragraph
- Provide helpers for add-paragraph and settings-menu interactions
- Replace individual settings-menu locators with a typed `settingsMenuItem()` accessor
- Support interactions with settings menus belonging to different paragraphs
- Use stable, component-specific locators instead of broad fallback selectors
### What type of PR is it?
Improvement
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-6517
### How should this be tested?
From `zeppelin-web-angular/`, run:
```bash
npm run e2e:fast -- tests/notebook/paragraph/paragraph-functionality.spec.ts
```
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6517] Add E2E tests for notebook paragraph components [zeppelin]
Posted by "voidmatcha (via GitHub)" <gi...@apache.org>.
voidmatcha commented on PR #5476:
URL: https://github.com/apache/zeppelin/pull/5476#issuecomment-5698194851
Merged into master (710edf25).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6517] Add E2E tests for notebook paragraph components [zeppelin]
Posted by "voidmatcha (via GitHub)" <gi...@apache.org>.
voidmatcha merged PR #5476:
URL: https://github.com/apache/zeppelin/pull/5476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6517] Add E2E tests for notebook paragraph components [zeppelin]
Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5476:
URL: https://github.com/apache/zeppelin/pull/5476#issuecomment-5652735524
Could you rebase this onto master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org