You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Vova Vysotskyi (Jira)" <ji...@apache.org> on 2021/01/12 23:08:00 UTC
[jira] [Resolved] (DRILL-5405) Add missing operator types without
dependency on protobuf enum
[ https://issues.apache.org/jira/browse/DRILL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vova Vysotskyi resolved DRILL-5405.
-----------------------------------
Fix Version/s: (was: 2.0.0)
1.19.0
Resolution: Fixed
Fixed in https://github.com/apache/drill/commit/3d1bc2c07e620187bb251cf61bac1858f4dcceda
> Add missing operator types without dependency on protobuf enum
> --------------------------------------------------------------
>
> Key: DRILL-5405
> URL: https://issues.apache.org/jira/browse/DRILL-5405
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.10.0
> Reporter: Arina Ielchiieva
> Assignee: Vova Vysotskyi
> Priority: Minor
> Fix For: 1.19.0
>
> Attachments: maprdb_sub_scan.JPG, unknown_operator.JPG
>
>
> Source - https://github.com/apache/drill/pull/214#discussion_r42687575
> When operators are not added into CoreOperatorType enum, they are displayed on Web UI as UNKNOWN_OPERATOR.
> Screenshots:
> now -> unknown_operator.JPG
> should be -> maprdb_sub_scan.JPG
> Though plugins work fine without this changes, it's still would be nice to display operator type on Web UI.
> But dependency on protobuf enum removes the ability for format plugins to truly be drop-in pluggable.
> In this case as option we may need to refactor this interface to just return a String and not use the protobuf enum, or have a separate "notes" field if we want to have a generic filescan operator ID in this enum with extra data to say what kind of scan we used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)