You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by httfighter <gi...@git.apache.org> on 2018/07/20 09:32:08 UTC
[GitHub] spark pull request #21826: [SPARK-24872] Remove the symbol ���||��� of the �...
GitHub user httfighter opened a pull request:
https://github.com/apache/spark/pull/21826
[SPARK-24872] Remove the symbol “||” of the “OR” operation
## What changes were proposed in this pull request?
“||” will perform the function of STRING concat, and it is also the symbol of the "OR" operation.
When I want use "||" as "OR" operation, I find that it perform the function of STRING concat，
spark-sql> explain extended select * from aa where id==1 || id==2;
== Parsed Logical Plan ==
'Project [*]
+- 'Filter (('id = concat(1, 'id)) = 2)
+- 'UnresolvedRelation `aa`
spark-sql> select "abc" || "DFF" ;
And the result is "abcDFF".
In predicates.scala, "||" is the symbol of "Or" operation. Could we remove it?
## How was this patch tested?
We can test this patch with unit tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/httfighter/spark SPARK-24872
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21826.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21826
----
commit fb98029c451023789a2c7fa0e758c6c8790bbaea
Author: 韩田田00222924 <ha...@...>
Date: 2018-07-20T09:19:54Z
SPARK-24872 Remove the symbol “||” of the “OR” operation
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21826
retest this please.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by httfighter <gi...@git.apache.org>.
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/21826
I did the following tests in mysql.
mysql> select "abc" || "def";
+----------------+
| "abc" || "def" |
+----------------+
| 0 |
+----------------+
mysql> select "abc" "def";
+--------+
| abc |
+--------+
| abcdef |
+--------+
mysql> select * from aa where id=1 || id=2;
+------+------+
| id | name |
+------+------+
| 1 | sdf |
| 2 | ader |
+------+------+
mysql> select * from aa where id=1 or id=2;
+------+------+
| id | name |
+------+------+
| 1 | sdf |
| 2 | ader |
+------+------+
It seems that it does not act as a string connector, but as an "or" operation. I don't know if my tests are correct.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93378/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21826
No we can't because you can still use string concat in filters, e.g.
colA || colB == "ab"
What is "||" here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #93714 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93714/testReport)** for PR 21826 at commit [`3743b79`](https://github.com/apache/spark/commit/3743b79d29d1bbbff3889c21921082cf6e67dd28).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93766/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21826
Looks it's gonna make a compilation failure and I see potential references referring this field. @httfighter, I think manual build and tests are required.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21826: [SPARK-24872] Replace the symbol '||' of Or opera...
Posted by httfighter <gi...@git.apache.org>.
Github user httfighter commented on a diff in the pull request:
https://github.com/apache/spark/pull/21826#discussion_r205934501
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/PredicateSuite.scala ---
@@ -455,4 +456,10 @@ class PredicateSuite extends SparkFunSuite with ExpressionEvalHelper {
interpreted.initialize(0)
assert(interpreted.eval(new UnsafeRow()))
}
+
+ test("[SPARK-24872] Replace the symbol '||' of Or operator with 'or'") {
--- End diff --
Thank you! I have made changes to the code. @HyukjinKwon
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21826
test this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93714/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21826
cc @gatorsmile @cloud-fan @HyukjinKwon this is a good thing to do?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #93596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93596/testReport)** for PR 21826 at commit [`7ab449f`](https://github.com/apache/spark/commit/7ab449f6946ea6333ad3a53ab59d829d466c603e).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #93714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93714/testReport)** for PR 21826 at commit [`3743b79`](https://github.com/apache/spark/commit/3743b79d29d1bbbff3889c21921082cf6e67dd28).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21826
Jenkins, test this please.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21826: [SPARK-24872] Remove the symbol ���||��� of the �...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21826#discussion_r204190916
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ---
@@ -442,8 +442,6 @@ case class Or(left: Expression, right: Expression) extends BinaryOperator with P
override def inputType: AbstractDataType = BooleanType
- override def symbol: String = "||"
--- End diff --
I think this won't be compiled?
```
class Or needs to be abstract, since method symbol in class BinaryOperator of type => String is not defined
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #94501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94501/testReport)** for PR 21826 at commit [`3743b79`](https://github.com/apache/spark/commit/3743b79d29d1bbbff3889c21921082cf6e67dd28).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by httfighter <gi...@git.apache.org>.
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/21826
It failed again. I don't know what the problem is. Could you help me trigger it again?@viirya
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #93766 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93766/testReport)** for PR 21826 at commit [`3743b79`](https://github.com/apache/spark/commit/3743b79d29d1bbbff3889c21921082cf6e67dd28).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by httfighter <gi...@git.apache.org>.
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/21826
Thank you very much! @viirya
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #93378 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93378/testReport)** for PR 21826 at commit [`fb98029`](https://github.com/apache/spark/commit/fb98029c451023789a2c7fa0e758c6c8790bbaea).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21826
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #93596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93596/testReport)** for PR 21826 at commit [`7ab449f`](https://github.com/apache/spark/commit/7ab449f6946ea6333ad3a53ab59d829d466c603e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21826: [SPARK-24872] Remove the symbol ���||��� of the �...
Posted by httfighter <gi...@git.apache.org>.
Github user httfighter commented on a diff in the pull request:
https://github.com/apache/spark/pull/21826#discussion_r204274497
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ---
@@ -442,8 +442,6 @@ case class Or(left: Expression, right: Expression) extends BinaryOperator with P
override def inputType: AbstractDataType = BooleanType
- override def symbol: String = "||"
--- End diff --
I am sorry for this error, I will try to avoid it in the future.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21826: [SPARK-24872] Remove the symbol ���||��� of the �...
Posted by httfighter <gi...@git.apache.org>.
Github user httfighter commented on a diff in the pull request:
https://github.com/apache/spark/pull/21826#discussion_r204274481
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ---
@@ -442,8 +442,6 @@ case class Or(left: Expression, right: Expression) extends BinaryOperator with P
override def inputType: AbstractDataType = BooleanType
- override def symbol: String = "||"
--- End diff --
I am sorry for this error, I will try to avoid it in the future.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21826
I am not sure there is much to do here. `OR` is the standard syntax for or, and `||` is pretty common syntax for string concatenation. Removing `||` breaks binary compatibility and also makes our SQL dialect less compatible with others. The only thing I think that might be worth fixing is the precedence of `||` in the example, parsing `id==1 || id==2` into `('id = concat(1, 'id)) = 2` is a bit weird IMO.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #94501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94501/testReport)** for PR 21826 at commit [`3743b79`](https://github.com/apache/spark/commit/3743b79d29d1bbbff3889c21921082cf6e67dd28).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by httfighter <gi...@git.apache.org>.
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/21826
I have submitted a new code. Could you help me review the code? Thank you! @HyukjinKwon @viirya @gatorsmile @rxin @hvanhovell
In Hive, "||" performs the function of STRING concat, the symbol of "Or" operator is 'or'
hive> explain select * from aa where id=1 or id=2;
and its Filter part is
predicate: ((id = 1) or (id = 2)) (type: boolean)
In Spark, "||" also performs the function of STRING concat. We can change the symbol of "Or" operator to 'or'.
spark-sql> explain extended select * from aa where id=1 or id=2;
| == Parsed Logical Plan ==
'Project [*]
+- 'Filter (('id = 1) or ('id = 2))
+- 'UnresolvedRelation `aa`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94501/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21826
retest this please.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #93378 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93378/testReport)** for PR 21826 at commit [`fb98029`](https://github.com/apache/spark/commit/fb98029c451023789a2c7fa0e758c6c8790bbaea).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21826
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93596/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21826
**[Test build #93766 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93766/testReport)** for PR 21826 at commit [`3743b79`](https://github.com/apache/spark/commit/3743b79d29d1bbbff3889c21921082cf6e67dd28).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21826: [SPARK-24872] Remove the symbol ���||��� of the �...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21826#discussion_r204192991
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala ---
@@ -442,8 +442,6 @@ case class Or(left: Expression, right: Expression) extends BinaryOperator with P
override def inputType: AbstractDataType = BooleanType
- override def symbol: String = "||"
--- End diff --
If you remove it, it will not compile.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by httfighter <gi...@git.apache.org>.
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/21826
I have a suggestion that I don't know if it is reasonable.
In our spark, since we already support “||” as a string concatenation function, I don't know if we can make such an improvement. In the SQL project part, we will use "||" as a string concatenation function. In the SQL filter part, we will use "||" as the “Or” operation.
@HyukjinKwon @viirya @gatorsmile @rxin @hvanhovell
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Remove the symbol ���||��� of the ���OR���...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21826
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21826: [SPARK-24872] Replace the symbol '||' of Or opera...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21826#discussion_r205713034
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/PredicateSuite.scala ---
@@ -455,4 +456,10 @@ class PredicateSuite extends SparkFunSuite with ExpressionEvalHelper {
interpreted.initialize(0)
assert(interpreted.eval(new UnsafeRow()))
}
+
+ test("[SPARK-24872] Replace the symbol '||' of Or operator with 'or'") {
--- End diff --
tiny nit: `[SPARK-24872] ` -> `SPARK-24872: `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21826: [SPARK-24872] Replace the symbol '||' of Or operator wit...
Posted by httfighter <gi...@git.apache.org>.
Github user httfighter commented on the issue:
https://github.com/apache/spark/pull/21826
The last test bulid failed, but all the test cases passed. I don't know what the problem is. Could you help me trigger it again? @HyukjinKwon
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org