You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "alizademhdi (via GitHub)" <gi...@apache.org> on 2024/07/21 11:27:09 UTC
[PR] Chart: add a specific internal IP address for the ClusterIP service [airflow]
alizademhdi opened a new pull request, #40912:
URL: https://github.com/apache/airflow/pull/40912
## Related issue:
#40676
add a specific internal IP address for the ClusterIP service in helm chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Chart: add a specific internal IP address for the ClusterIP service [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #40912:
URL: https://github.com/apache/airflow/pull/40912#discussion_r1705874694
##########
chart/values.yaml:
##########
@@ -2144,6 +2144,7 @@ pgbouncer:
service:
extraAnnotations: {}
+ ip: ~
Review Comment:
What do you think about `clusterIP` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Chart: add a specific internal IP address for the ClusterIP service [airflow]
Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 commented on PR #40912:
URL: https://github.com/apache/airflow/pull/40912#issuecomment-2252053045
changes looks good, can you add ut?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Chart: add a specific internal IP address for the ClusterIP service [airflow]
Posted by "alizademhdi (via GitHub)" <gi...@apache.org>.
alizademhdi commented on PR #40912:
URL: https://github.com/apache/airflow/pull/40912#issuecomment-2247646587
Hello @potiuk,
can you review this please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Chart: add a specific internal IP address for the ClusterIP service [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #40912:
URL: https://github.com/apache/airflow/pull/40912#issuecomment-2247672078
We avoid to call specific people unless we know they are related and interested here.
I think there are other reviewers already automatically assigned here.
if I am supposed to review every single PR here where others could do it as well - it's impossible with the amounts of PRs we have and very stressful in general - very mentally draining - so I deliberately limit the areas I am looking at. And chart is something I am not too "good at".
Also, by mentioning me you are decreasing chance that others will take a look because they think I will, so try to avoid that. I suggest you just generally ask for review and wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Chart: add a specific internal IP address for the ClusterIP service [airflow]
Posted by "alizademhdi (via GitHub)" <gi...@apache.org>.
alizademhdi commented on code in PR #40912:
URL: https://github.com/apache/airflow/pull/40912#discussion_r1709022236
##########
chart/values.yaml:
##########
@@ -2144,6 +2144,7 @@ pgbouncer:
service:
extraAnnotations: {}
+ ip: ~
Review Comment:
good suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Chart: add a specific internal IP address for the ClusterIP service [airflow]
Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 merged PR #40912:
URL: https://github.com/apache/airflow/pull/40912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org