You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by cjmay <gi...@git.apache.org> on 2016/01/17 18:17:08 UTC
[GitHub] thrift pull request: THRIFT-1313 implement compact protocol for c_...
GitHub user cjmay opened a pull request:
https://github.com/apache/thrift/pull/795
THRIFT-1313 implement compact protocol for c_glib library
Implement compact protocol for c_glib library, add tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cjmay/thrift THRIFT-1313
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/795.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #795
----
commit a9a3cca8aae83af6cbc3ecbe22a4ebacb143fc79
Author: Chandler May <cj...@gmail.com>
Date: 2016-01-10T06:01:10Z
THRIFT-1313 implement compact protocol for c_glib library
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-1313 implement compact protocol for c_...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/795
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-1313 implement compact protocol for c_...
Posted by bufferoverflow <gi...@git.apache.org>.
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/795#issuecomment-172357194
Great work!
Could you please add this to ``test/tests.json`` as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-1313 implement compact protocol for c_...
Posted by cjmay <gi...@git.apache.org>.
Github user cjmay commented on the pull request:
https://github.com/apache/thrift/pull/795#issuecomment-172706228
Thanks for the feedback! I added the c_glib compact protocol to test/tests.json and cross tests now pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-1313 implement compact protocol for c_...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/795#issuecomment-172728554
Your commitment to testing is admirable! Looks good to me for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-1313 implement compact protocol for c_...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/795#issuecomment-172358594
Along with adding it to tests.json, ensure `make cross` passes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---