You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Christos Kozyrakis <ko...@gmail.com> on 2015/01/08 23:39:45 UTC
Review Request 29727: Style fixes in recent patch for service
discovery info.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Timothy Chen.
Repository: mesos-git
Description
-------
Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
Diffs
-----
include/mesos/mesos.proto 5b2813de27cda155525733438919d2274194c17c
src/common/http.cpp 915cba10725685da55a53b249b8b676b5e229d86
src/common/protobuf_utils.cpp 3a5e5d3dc915b4817635a01105f8006ac18ae59e
Diff: https://reviews.apache.org/r/29727/diff/
Testing
-------
make check
Thanks,
Christos Kozyrakis
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review67316
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Jan. 8, 2015, 2:39 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29727/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 2:39 p.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5b2813de27cda155525733438919d2274194c17c
> src/common/http.cpp 915cba10725685da55a53b249b8b676b5e229d86
> src/common/protobuf_utils.cpp 3a5e5d3dc915b4817635a01105f8006ac18ae59e
>
> Diff: https://reviews.apache.org/r/29727/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review67317
-----------------------------------------------------------
src/common/http.cpp
<https://reviews.apache.org/r/29727/#comment111312>
Comment needs to end with a period
src/common/http.cpp
<https://reviews.apache.org/r/29727/#comment111311>
BenH's comment: This all actually can be called as JSON::Protobuf(discovery)
- Timothy Chen
On Jan. 8, 2015, 10:39 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29727/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 10:39 p.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5b2813de27cda155525733438919d2274194c17c
> src/common/http.cpp 915cba10725685da55a53b249b8b676b5e229d86
> src/common/protobuf_utils.cpp 3a5e5d3dc915b4817635a01105f8006ac18ae59e
>
> Diff: https://reviews.apache.org/r/29727/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review70920
-----------------------------------------------------------
Bad patch!
Reviews applied: [29727]
Failed command: ./support/apply-review.sh -n -r 29727
Error:
2015-02-04 03:33:25 URL:https://reviews.apache.org/r/29727/diff/raw/ [6997/6997] -> "29727.patch" [1]
error: patch failed: include/mesos/mesos.proto:1050
error: include/mesos/mesos.proto: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Feb. 4, 2015, 1:30 a.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29727/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 1:30 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5b2813d
> src/common/http.cpp 915cba1
> src/common/protobuf_utils.cpp 3a5e5d3
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/29727/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review71046
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29727]
All tests passed.
- Mesos ReviewBot
On Feb. 4, 2015, 6:59 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29727/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 6:59 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 2861216
> src/common/http.cpp 915cba1
> src/common/protobuf_utils.cpp c4b53a8
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/29727/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Christos Kozyrakis <ko...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 10:59 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, and Timothy Chen.
Changes
-------
Created new diff that can be automatically merged.
Repository: mesos
Description
-------
Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
Diffs (updated)
-----
include/mesos/mesos.proto 2861216
src/common/http.cpp 915cba1
src/common/protobuf_utils.cpp c4b53a8
src/tests/master_tests.cpp 678d27f
Diff: https://reviews.apache.org/r/29727/diff/
Testing
-------
make check
Thanks,
Christos Kozyrakis
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Adam B <ad...@mesosphere.io>.
> On Feb. 3, 2015, 6:07 p.m., Adam B wrote:
> > Ship It!
Committed. Please mark this review as "Submitted"
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review70901
-----------------------------------------------------------
On Feb. 4, 2015, 10:59 a.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29727/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 10:59 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 2861216
> src/common/http.cpp 915cba1
> src/common/protobuf_utils.cpp c4b53a8
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/29727/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review70901
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Feb. 3, 2015, 5:30 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29727/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 5:30 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5b2813d
> src/common/http.cpp 915cba1
> src/common/protobuf_utils.cpp 3a5e5d3
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/29727/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Michael Park <mc...@gmail.com>.
> On Feb. 4, 2015, 1:36 a.m., switched to 'mcypark' wrote:
> > src/tests/master_tests.cpp, line 2880
> > <https://reviews.apache.org/r/29727/diff/3/?file=846895#file846895line2880>
> >
> > style nit: should be indented 4 spaces here
Sorry for the mess regarding "switched to 'mcypark'" above, I messed up there.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review70890
-----------------------------------------------------------
On Feb. 4, 2015, 1:30 a.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29727/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 1:30 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5b2813d
> src/common/http.cpp 915cba1
> src/common/protobuf_utils.cpp 3a5e5d3
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/29727/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by switched to 'mcypark' <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review70890
-----------------------------------------------------------
src/tests/master_tests.cpp
<https://reviews.apache.org/r/29727/#comment116349>
style nit: should be indented 4 spaces here
- switched to 'mcypark'
On Feb. 3, 2015, 8:30 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29727/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 8:30 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5b2813d
> src/common/http.cpp 915cba1
> src/common/protobuf_utils.cpp 3a5e5d3
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/29727/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Christos Kozyrakis <ko...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 5:30 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, and Timothy Chen.
Changes
-------
Consistent wrapping.
Repository: mesos
Description
-------
Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
Diffs (updated)
-----
include/mesos/mesos.proto 5b2813d
src/common/http.cpp 915cba1
src/common/protobuf_utils.cpp 3a5e5d3
src/tests/master_tests.cpp 678d27f
Diff: https://reviews.apache.org/r/29727/diff/
Testing
-------
make check
Thanks,
Christos Kozyrakis
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review70878
-----------------------------------------------------------
src/tests/master_tests.cpp
<https://reviews.apache.org/r/29727/#comment116325>
s/2,p/2, p/ (space after comma)
src/tests/master_tests.cpp
<https://reviews.apache.org/r/29727/#comment116326>
space after ','
- Adam B
On Feb. 3, 2015, 4:39 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29727/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 4:39 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5b2813d
> src/common/http.cpp 915cba1
> src/common/protobuf_utils.cpp 3a5e5d3
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/29727/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Christos Kozyrakis <ko...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 4:39 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, and Timothy Chen.
Changes
-------
Style fixes based on Adam's suggestions.
Repository: mesos
Description
-------
Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
Diffs (updated)
-----
include/mesos/mesos.proto 5b2813d
src/common/http.cpp 915cba1
src/common/protobuf_utils.cpp 3a5e5d3
src/tests/master_tests.cpp 678d27f
Diff: https://reviews.apache.org/r/29727/diff/
Testing
-------
make check
Thanks,
Christos Kozyrakis
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review69976
-----------------------------------------------------------
Made another pass over the DiscoveryInfo changes and found a handful more style issues. Fix these and then I'll get it committed for you.
include/mesos/mesos.proto
<https://reviews.apache.org/r/29727/#comment114849>
"Remove this newline, to be consistent with the rest of our protobufs." - BenM, from previous review
src/tests/master_tests.cpp
<https://reviews.apache.org/r/29727/#comment114850>
Prefer CopyFrom unless you explicitly know that you need MergeFrom.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/29727/#comment114851>
You could do a `using process::http::Response` at the top, since this file is using Response so much. Not necessary, but bonus points!
src/tests/master_tests.cpp
<https://reviews.apache.org/r/29727/#comment114854>
We prefer to wrap after the '=', if possible. (Here and elsewhere)
Note that we only indent 2 spaces after wrapping on the =.
```Result<JSON::String> taskName =
parse.get().find<JSON::String>("frameworks[0].tasks[0].name");```
src/tests/master_tests.cpp
<https://reviews.apache.org/r/29727/#comment114857>
Maybe `portsArray` would be a better name for one/both of these variables?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/29727/#comment114858>
Assert the size of the array before reading 2 values
src/tests/master_tests.cpp
<https://reviews.apache.org/r/29727/#comment114859>
labelsArray?
src/tests/master_tests.cpp
<https://reviews.apache.org/r/29727/#comment114860>
Assert size before reading values
- Adam B
On Jan. 13, 2015, 5:29 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29727/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 5:29 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5b2813d
> src/common/http.cpp 915cba1
> src/common/protobuf_utils.cpp 3a5e5d3
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/29727/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Christos Kozyrakis <ko...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 5:29 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Joris Van Remoortere, and Timothy Chen.
Repository: mesos-git
Description
-------
Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
Diffs
-----
include/mesos/mesos.proto 5b2813d
src/common/http.cpp 915cba1
src/common/protobuf_utils.cpp 3a5e5d3
src/tests/master_tests.cpp 678d27f
Diff: https://reviews.apache.org/r/29727/diff/
Testing
-------
make check
Thanks,
Christos Kozyrakis
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review67572
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29727]
All tests passed.
- Mesos ReviewBot
On Jan. 10, 2015, 1:06 a.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29727/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2015, 1:06 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5b2813d
> src/common/http.cpp 915cba1
> src/common/protobuf_utils.cpp 3a5e5d3
> src/tests/master_tests.cpp 678d27f
>
> Diff: https://reviews.apache.org/r/29727/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Christos Kozyrakis <ko...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/
-----------------------------------------------------------
(Updated Jan. 9, 2015, 5:06 p.m.)
Review request for mesos, Ben Mahler and Timothy Chen.
Changes
-------
More style fixes + switch to using JSON::Protobuf(discovery) for json to protobuf conversion.
Repository: mesos-git
Description
-------
Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
Diffs (updated)
-----
include/mesos/mesos.proto 5b2813d
src/common/http.cpp 915cba1
src/common/protobuf_utils.cpp 3a5e5d3
src/tests/master_tests.cpp 678d27f
Diff: https://reviews.apache.org/r/29727/diff/
Testing
-------
make check
Thanks,
Christos Kozyrakis
Re: Review Request 29727: Style fixes in recent patch for service
discovery info.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review67323
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29727]
All tests passed.
- Mesos ReviewBot
On Jan. 8, 2015, 10:39 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29727/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 10:39 p.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Style fixes in recent patch for service discovery info. See https://reviews.apache.org/r/29473/ and final comments by Ben Mahler.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5b2813de27cda155525733438919d2274194c17c
> src/common/http.cpp 915cba10725685da55a53b249b8b676b5e229d86
> src/common/protobuf_utils.cpp 3a5e5d3dc915b4817635a01105f8006ac18ae59e
>
> Diff: https://reviews.apache.org/r/29727/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Christos Kozyrakis
>
>