[GitHub] dubee commented on a change in pull request #3704: Provide invoker maintenance mode

[GitBox <gi...@apache.org>]

dubee commented on a change in pull request #3704: Provide invoker maintenance mode
URL: https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r191568606
 
 

 ##########
 File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
 ##########
 @@ -188,5 +188,20 @@ object Invoker {
     BasicHttpService.startHttpService(new BasicRasService {}.route, port)(
       actorSystem,
       ActorMaterializer.create(actorSystem))
+
+    Signal.handle(
+      new Signal("USR2"),
+      new SignalHandler() {
+        override def handle(signal: Signal) = {
+          signal.getName match {
+            case "USR2" =>
+              logger.info(this, s"Stopping health scheduler")
+              actorSystem.stop(healthScheduler)
+              while (true) {}
 
 Review comment:
   For a graceful shutdown, we would need to make sure user' containers are not running and possibly check that the queue is empty.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services