[jira] [Commented] (NIFI-4357) Improve template XML loading globally

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157455#comment-16157455 ] 

ASF GitHub Bot commented on NIFI-4357:
--------------------------------------

GitHub user alopresto opened a pull request:

    https://github.com/apache/nifi/pull/2134

    NIFI-4357 Global improvement of XML unmarshalling

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alopresto/nifi NIFI-4357

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2134
    
----
commit 0fa6ca17629094845bc9e374f442e3617205f1fd
Author: Andy LoPresto <al...@apache.org>
Date:   2017-09-06T23:45:13Z

    NIFI-4353 Added XmlUtils class.
    Added unit test.
    Added XXE test resource.

commit 91ff58d038d3afe6a6c1aa13226a2c3050612938
Author: Andy LoPresto <al...@apache.org>
Date:   2017-09-07T18:57:33Z

    NIFI-4357 Refactored JAXB unmarshalling globally to prevent XXE attacks.
    Refactored duplicated/legacy code.

commit f2b396eb629f3adadd56eaff86666ce9ee245426
Author: Andy LoPresto <al...@apache.org>
Date:   2017-09-07T19:03:35Z

    NIFI-4357 Cleaned up commented code.
    Switched from FileInputStream back to StreamSource in AuthorizerFactoryBean.

----


> Improve template XML loading globally
> -------------------------------------
>
>                 Key: NIFI-4357
>                 URL: https://issues.apache.org/jira/browse/NIFI-4357
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.3.0
>            Reporter: Andy LoPresto
>            Assignee: Andy LoPresto
>             Fix For: 1.4.0
>
>
> We should improve the template loading code (uses JAXBContext). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)